[kronolith] sql driver patch - multiday events

[Jesse Wolff]

Good, I'm glad you didn't have to put in any driver specific checks since I'm 
sure you want to keep it abstracted outside of sql.php and mcal.php.

Jesse.

Quoting Jan Schneider <jan@horde.org>:

> Zitat von Jesse Wolff <jesse_wolff@yahoo.com>:
> 
> > 1) The times for recurrence events don't show correctly when the
> recurrence
> > 
> > start date is greater than the current time.
> > 
> > This problem is due to the second part of the if statement on line 33-34:
> > 
> > if (!$event->hasRecurType(KRONOLITH_RECUR_NONE) &&
> >                  $event->startTimestamp < $now) {
> > 
> > I can't find a reason why this check is necessary for the sql driver and
> it
> > 
> > causes the above problem. If mcal doesn't need it as well we can take it
> out
> 
> It took my some time to remember why we used this line and I think it was a
> 
> really dirty hack to test for recurrence. Anyway, removing the second test 
> works well with mcal so it's gone now.
> 
> > 2) The times for multi-day events don't show up correctly.
> > 
> > This is due to line 44:
> > 
> > $event->endTimestamp = $event->startTimestamp + $event->durMin * 60;
> > 
> > For the sql driver it shouldn't be included. If it's not needed by mcal
> it
> > can 
> > be deleted. If it's needed by mcal it will need to be wrapped by a check
> for
> 
> This has just been in the wrong line. It should recalculate the event end if
> we 
> recalculated the event start because of recurrence.
> 
> All fixed now in cvs.
> 
> Thanks again,
> Jan.
> 
> :::::::::::::::::::::::::::::::::::::::: 
> AMMMa AG - discover your knowledge
> :::::::::::::::::::::::::::
> Detmolder Str. 25-33 :: D-33604 Bielefeld
> fon +49.521.96878-0 :: fax  +49.521.96878-20
> http://www.ammma.de
> ::::::::::::::::::::::::::::::::::::::::::::::
> 
> -- 
> Kronolith mailing list: http://horde.org/kronolith/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
>