[kronolith] Kronolith search patch

Meilof meilof at wanadoo.nl
Sat Jul 17 12:09:51 PDT 2004


Hello,

I announced I was going to try and implement search support for 
Kronolith, and the first revision of my patch is now done:

http://home.wanadoo.nl/meilof/filez/kronolith-search/kronolith-search-diff-1.gz

I would like to hear your comments about this. I have a couple of 
remarks to make myself:

The search functionality in the backend is done by means of the search 
function for backends, which has a Kronolith_Event as its argument 
containing the fields to search for (all fields that should not be 
looked for are set to null). I have written a generic implementation 
that will retrieve all events in a given time span and then filter, and 
an implementation for the SQL backend that will put all conditions in 
the SQL query.

The advanced search is a bit of a cut-and-paste operation from the event 
editor currently, but there are just enough differences between 
searching and editing to make putting it in a shared file just as ugly I 
think... There is a bit of glue code to make the HTML returned by 
Driver.php happy, but nothing really serious I think myself...

I noticed by the way that picking a date from the popup window in 
Konqueror causes an error in the search as well as the edit event pages. 
I'm quite sure I didn't cause it, but I'll see if I can fix it anyway.


Meilof
  -- meilof at wanadoo.nl


More information about the kronolith mailing list