[kronolith] freebusy URL not working AND event_alarm > 0 ?

[Jan Schneider]

Zitat von LALOT Dominique <dom.lalot at gmail.com>:

> 2011/8/26 Jan Schneider <jan at horde.org>
>
>>
>> Zitat von LALOT Dominique <dom.lalot at gmail.com>:
>>
>>
>>  Hello,
>>>
>>> I was wondering why the FB were not working, so I looked at the SQL:
>>>
>>> SELECT event_id, event_uid, event_description, event_location,
>>> event_private, event_status, event_attendees, event_title,
>>> event_recurcount,
>>> event_url, event_recurtype, event_recurenddate, event_recurinterval,
>>> event_recurdays, event_start, event_end, event_allday, event_alarm,
>>> event_alarm_methods, event_modified, event_exceptions, event_creator_id,
>>> event_resources, event_baseid, event_exceptionoriginaldate FROM
>>> kronolith_events WHERE calendar_id = 'xxx' *AND event_alarm > 0* AND
>>> ((event_end >= '2011-08-23 22:00:00') OR (event_recurenddate >=
>>> '2011-08-23
>>> 22:00:00' AND event_recurtype <> 0))
>>>
>>
>> What makes you think that this query is from generating free/busy
>> information. Kronolith_FreeBusy::generate() does *not* request alarm-only
>> events.
>>
>
>
> Well, I was normally alone, but it took times to get read of activesync
> pollings, alarms (I am not sure to use in prod..) It seems you are right.
> But just having a loop in IE http://bugs.horde.org/ticket/10462 I was
> tailing -f the mysql log and the loop was looking at alarms massively.
>
> Well, seems that FB is not finding the calendar id, should be somewhere in a
> hook to write..

No, it's a preference and it falls back to the user's default calendar.

> SELECT event_id, event_uid, event_description, event_location,
> event_private, event_status, event_attendees, event_title, event_recurcount,
> event_url, event_recurtype, event_recurenddate, event_recurinterval,
> event_recurdays, event_start, event_end, event_allday, event_alarm,
> event_alarm_methods, event_modified, event_exceptions, event_creator_id,
> event_resources, event_baseid, event_exceptionoriginaldate FROM
> kronolith_events WHERE *cal     endar_id = NULL* AND ((event_end >=
> '2011-08-25 22:00:00' AND event_start <= '2011-09-25 21:59:59') OR
> (event_recurenddate >= '2011-08-25 22:00:00' AND event_start <= '2011-09-25
> 21:59:59' AND event_recurtype <> 0))

I can't see anywhere in the code how this could happen.

If found another issue with generating FB data from internal calendars  
though, try what I committed.

> But nevertheless, the management of alarms could be painful with thousands
> users. And if somebody shares with me (10 shares for me in prod), it makes
> 10 selects quite often.

No idea what this has to do with the other, or how this is a  
performance problem.