[kronolith] issue on Firefox 134

[Michael Menge]

Hi,

@Pascal Thank you for your fix.

  we had the same reports, and we where able to fix them with your patch.
  The file that needs changing is kronolith/js/kronolith.js

@Devs

I was just wondering about the comment above the fixed line?

// FIXME: spacing is hardcoded for IE 7 because it doesn't know about
// border-spacing, but still uses it. WTF?

IE 7 was replaced by IE8 in 2009. Do we still need this at all?

Kind Regards

    Michael Menge


Quoting Pascal Rigaux <pascal.rigaux at univ-paris1.fr>:

> Hi,
>
> Since Firefox 134, our users have issues on Kronolith for  
> day/week/workweek views.
>
> The issue comes from:
>
>     spacing = td.up('table').getStyle('borderSpacing');
>     ...
>     spacing = spacing ? parseInt($w(spacing)[1], 10) : 2;
>
> The code expects something like "1px 1px" but Firefox 134 returns "1px"
>
> It corresponds to the CSS: "border-spacing: 1px;"
>
> NB : $w is mostly a string split on spaces.
>
>
> We used the following fix:
>
>     spacing = spacing ? parseInt($w(spacing).pop(), 10) : 2;
>
>
> cu
> -- 
> Pascal Rigaux
> -- 
> kronolith mailing list
> Frequently Asked Questions: http://wiki.horde.org/FAQ
> To unsubscribe, mail: kronolith-unsubscribe at lists.horde.org



--
--------------------------------------------------------------------------------
Michael Menge                          Tel.: (49) 7071 / 29-70316
Universität Tübingen                   Fax.: (49) 7071 / 29-5912
Zentrum für Datenverarbeitung          mail:  
michael.menge at zdv.uni-tuebingen.de
Wächterstraße 76
72074 Tübingen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6607 bytes
Desc: S/MIME-Signatur
URL: <https://lists.horde.org/archives/kronolith/attachments/20250110/1a8c0c2c/attachment.bin>