From asa at ursc.gov.in Mon Jan 13 13:14:01 2025 From: asa at ursc.gov.in (ANANT S ATHAVALE) Date: Mon, 13 Jan 2025 18:44:01 +0530 Subject: [kronolith] issue on Firefox 134 In-Reply-To: <20250110134059.Horde.lDwLhZPWKDmHcbRcXGyX_Cj@webmail.uni-tuebingen.de> References: <263665d4-f920-4b44-bda8-f11f394de0b6@univ-paris1.fr> <20250110134059.Horde.lDwLhZPWKDmHcbRcXGyX_Cj@webmail.uni-tuebingen.de> Message-ID: <20250113132200.90EF63F37C@lists.horde.org> ----- Message from Michael Menge --------- Date: Fri, 10 Jan 2025 13:40:59 +0100 From: Michael Menge Subject: Re: [kronolith] issue on Firefox 134 To: kronolith at lists.horde.org > Hi, > > @Pascal Thank you for your fix. > > we had the same reports, and we where able to fix them with your patch. > The file that needs changing is kronolith/js/kronolith.js > > @Devs > > I was just wondering about the comment above the fixed line? > > // FIXME: spacing is hardcoded for IE 7 because it doesn't know about > // border-spacing, but still uses it. WTF? > > IE 7 was replaced by IE8 in 2009. Do we still need this at all? > > Kind Regards > > Michael Menge > > > Quoting Pascal Rigaux : > >> Hi, >> >> Since Firefox 134, our users have issues on Kronolith for >> day/week/workweek views. >> >> The issue comes from: >> >> spacing = td.up('table').getStyle('borderSpacing'); >> ... >> spacing = spacing ? parseInt($w(spacing)[1], 10) : 2; >> >> The code expects something like "1px 1px" but Firefox 134 returns "1px" >> >> It corresponds to the CSS: "border-spacing: 1px;" >> >> NB : $w is mostly a string split on spaces. >> >> >> We used the following fix: >> >> spacing = spacing ? parseInt($w(spacing).pop(), 10) : 2; >> >> >> cu >> -- >> Pascal Rigaux >> -- >> kronolith mailing list >> Frequently Asked Questions: http://wiki.horde.org/FAQ >> To unsubscribe, mail: kronolith-unsubscribe at lists.horde.org > > > > -- > -------------------------------------------------------------------------------- > Michael Menge Tel.: (49) 7071 / 29-70316 > Universität Tübingen Fax.: (49) 7071 / 29-5912 > Zentrum für Datenverarbeitung mail: > michael.menge at zdv.uni-tuebingen.de > Wächterstraße 76 > 72074 Tübingen ----- End message from Michael Menge ----- Is this change required for Horde 6 or Horde 5.2.x? If it is required for Horde 5.2.x, will it cause any issues, if not yet upgraded to Firefox 134? -- सादर धन्यवाद/ Thanks & Regards अनंत / Anant ------------------------------------------------------------------------------ Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message. Website: https://www.ursc.gov.in ------------------------------------------------------------------------------ From pascal.rigaux at univ-paris1.fr Mon Jan 13 13:31:41 2025 From: pascal.rigaux at univ-paris1.fr (Pascal Rigaux) Date: Mon, 13 Jan 2025 14:31:41 +0100 Subject: [kronolith] issue on Firefox 134 In-Reply-To: <20250113132200.90EF63F37C@lists.horde.org> References: <263665d4-f920-4b44-bda8-f11f394de0b6@univ-paris1.fr> <20250110134059.Horde.lDwLhZPWKDmHcbRcXGyX_Cj@webmail.uni-tuebingen.de> <20250113132200.90EF63F37C@lists.horde.org> Message-ID: <5c1cee56-6609-48bb-84c2-8b0516368998@univ-paris1.fr> On 13/01/2025 14:14, ANANT S ATHAVALE wrote: > > Since Firefox 134, our users have issues on Kronolith for day/week/workweek views. > > [...] > > Is this change required for Horde 6 or Horde 5.2.x? Both. > If it is required for Horde 5.2.x, will it cause any issues, if not yet upgraded to Firefox 134? It is a safe change. No regression on other browsers. cu