[sork] passwd and md5 in CVS HEAD

Amith Varghese amith at xalan.com
Thu Dec 19 16:26:17 PST 2002


> > lib/Driver.php (split the md5 case into two: md5-hex and md5-base64)
> 
> Doesn't seem to be in CVS, I'll put it there asap.

thanks

> 
> > lib/Driver/ldap.php (restored it to the original)
> 
> Your patch removes the function encryptPassword, but not the reference to it.
> Should still work, but since there are two calls to it, we should make them
> the same (parent:: vs $this->).

yup, i agree

> 
> > config/backends.php.dist
> > (added the supported types for encryption/hashing including the md5-hex and
> > md5-base64 encryption/hashing types  I also added alot of comments about
> how
> > to pick the right one)
> 
> Seems to already be in CVS.

i didn't see any commits on this from the cvs list.  guess i missed it.

> 
> > docs/INSTALL
> > (I updated the ldap docs to list all of the encryption types supported. 
> also
> > removed some incorrect information.  In addition I added a SQL section and
> > explained when to use md5-hex)
> 
> Seems to already be in CVS.

again, i must have missed this

> 
> > Please let me know if i left anything out and please test - especially you
> > Mike C :)
> 
> Yes, ditto.  Once I get this cleaned up and committed.
> 
> You also left a debugging line in main.php that would cause a security issue.
> Won't include that one...

ouch... bad amith.  sorry about that.

thanks
amith


More information about the sork mailing list