[sork] Patch for vacation forwards-driver (.forward-parser)

Espen Jürgensen espen at hhkol.dk
Tue Mar 30 14:14:43 PST 2004


Hi folks,

Here is a patch which only fixes a very small problem, but has potential
to fix many more. Basically it adds a .forward file parser to the dot
forward driver in Vacation.

Currently, vacation reports that vacation notices are active even if no
.forward file is present, since it only checks .vacation.msg. This patch
changes the driver so it checks .forward instead.

So, that's the small fix which the patch solves in present form.
However, the parser is also a first step to solve some more grave
problems:

1) Vacation and Forwards co-existence
Currently, forwards and vacation step on each others toes in a manner,
which makes it virtually impossible to run them alongside. They happily
delete each others settings because they aren't able to understand the
contents of the .forward-file.

2) Presentation of current settings
Vacation and Forward do a poor job at presenting current settings.
Vacation doesn't show aliases, and it doesn't move the radio button
according to what the current setting is. isKeepLocal() doesn't work in
Forwards. And again co-existence is poor. If you set a vacation-notice
with 'keep local copy', then suddenly Forwards reports that forwarding
is enabled.

The parser is the first step to solve the above problems. This parser is
made so it can be used unchanged in Forwards as well. And with a couple
of other alterations to the dot forward drivers, they could be made to
respect each others changes, and report all settings.

I would be happy to make the rest of these changes, but before I proceed
I would like to hear, if it's at all desired. Anyway, here is the first
step, the forwards-parser.

Regards,
Espen


-------------- next part --------------
A non-text attachment was scrubbed...
Name: forwards.patch
Type: text/x-patch
Size: 3179 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20040331/eee6cecf/forwards.bin


More information about the sork mailing list