[sork] [accounts] Update of accounts module

[Jan Schneider]

Zitat von Roel Gloudemans <roel at gloudemans.info>:

> Hi List,
>
> I've done some work on the accounts module. I've added some extra 
> features for
> LDAP users.
>
> If the LDAP attributes shadowMax, shadowWarning and shadowLastChange are
> present, the date of that last password change is showed and a warning is
> generated if the password is about to expire.
>
> Additionally, the module did a LDAP call for each attribute it was 
> getting. Ech
> call returned the complete attribute set. I've changed this logic. It 
> does one
> call to get teh information and then passes the information around.

Sounds very nice and the code looks good.

> Error reporting is also brushed up. The patches are included in the 
> mail. Please
> tell me what you think of it. This is my first real work on a horde module
> (however small), so expect me to violate the coding standards.

Indeed, please fix the indention (4 chars, no tabs) and the curly braces (on
the same line, only after function headers on the next).

I didn't look at the whole code, only at your patches. But wouldn't it
perhaps make sense to use the account data only internally inside the
drivers instead of passing them in the $information variable around? The
getAccount() function could be made private and keep the account data in a
static variable.

> (I also had to update the localhost (POSIX) driver, but since I'm not 
> using it I
> didn't test it)
>
> Cheers,
> Roel.



Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting.php