[sork] [accounts] Update of accounts module

[Roel Gloudemans]

Hi Jan, Chuck,

I modified the patches. (I even read the coding standards document). Please
excuse me if there are any (stupid) mistakes left; working on Horde has me
realizing what a sloppy PHP programmer I am, so it is a bit of learning on the
job.

I also updated the accompanying patch for the passwd ldap driver to the coding
standards and included it.

Cheers,
Roel.

----- Message from jan at horde.org ---------    Date: Sun,  8 Aug 2004 22:09:18
+0200    From: Jan Schneider <jan at horde.org>Reply-To: Jan Schneider
<jan at horde.org> Subject: Re: [sork] [accounts] Update of accounts module
To: sork at lists.horde.org

> Zitat von Roel Gloudemans <roel at gloudemans.info>:
>
>> Hi List,
>>
>> I've done some work on the accounts module. I've added some extra 
>> features for
>> LDAP users.
>>
>> If the LDAP attributes shadowMax, shadowWarning and shadowLastChange are
>> present, the date of that last password change is showed and a warning is
>> generated if the password is about to expire.
>>
>> Additionally, the module did a LDAP call for each attribute it was 
>> getting. Ech
>> call returned the complete attribute set. I've changed this logic. 
>> It does one
>> call to get teh information and then passes the information around.
>
> Sounds very nice and the code looks good.
>
>> Error reporting is also brushed up. The patches are included in the 
>> mail. Please
>> tell me what you think of it. This is my first real work on a horde module
>> (however small), so expect me to violate the coding standards.
>
> Indeed, please fix the indention (4 chars, no tabs) and the curly braces (on
> the same line, only after function headers on the next).
>
> I didn't look at the whole code, only at your patches. But wouldn't it
> perhaps make sense to use the account data only internally inside the
> drivers instead of passing them in the $information variable around? The
> getAccount() function could be made private and keep the account data in a
> static variable.
>
>> (I also had to update the localhost (POSIX) driver, but since I'm 
>> not using it I
>> didn't test it)
>>
>> Cheers,
>> Roel.
>
>
>
> Jan.
>
> --
> Do you need professional PHP or Horde consulting?
> http://horde.org/consulting.php
> --
> Sork mailing list - Join the hunt: http://horde.org/bounties/#sork
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: sork-unsubscribe at lists.horde.org


----- End message from jan at horde.org -----


-------------- next part --------------
A non-text attachment was scrubbed...
Name: accounts.pot.patch
Type: text/x-patch
Size: 1700 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20040811/d93313f7/accounts.pot.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ldap.php.patch
Type: text/x-patch
Size: 8351 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20040811/d93313f7/ldap.php.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: localhost.php.patch
Type: text/x-patch
Size: 3649 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20040811/d93313f7/localhost.php.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: main.inc.patch
Type: text/x-patch
Size: 1891 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20040811/d93313f7/main.inc.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: main.php.patch
Type: text/x-patch
Size: 754 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20040811/d93313f7/main.php.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Driver.php.patch
Type: text/x-patch
Size: 3329 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20040811/d93313f7/Driver.php.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: passwd_ldap.php.patch
Type: text/x-patch
Size: 3971 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20040811/d93313f7/passwd_ldap.php.bin