[sork] Passwd backends

[Eric Rostetter]

Quoting "Peter Borg (horde)" <horde at peter-b.org>:

> I've recently installed Horde 3 and the various modules that are immediately
> available for it.
> 
> In addition, because it's an essential tool for my users, I've picked up the
> HEAD release of passwd from CVS to use it - seems to work fine for me!

Great!

> However, I had to modify it to be able to use it successfully as my various

Are you sure?

> authentications require the full username (Auth::getAuth) as opposed to the
> domain-stripped username (Auth::getBareAuth).

Isn't there a hook in it just for this purpose?

> I don't want users to be able
> to enter the username for which they want to change the password, nor to
> select the back-end.

Are not these configuration options?

> I was considering submitting a patch for this, but the modification I've
> made wouldn't necessarily suit everyone. Reviewing the options, I was
> wondering what people's views are on this.

I've not looked at the code recently, but I thought all those changes
were already there as configuration options.  If not, I'd support changes
to allow them as configuration changes.

> Clearly, there's a need for a
> parameter to control which type of username is presented to the user or
> passed to the backend, but should this be global for all backends, or
> backend specific.

It should be a hook, so it is more flexible.

> In which case, it seems fairly trivial to add an extra property to each
> back-end definition in backends.php; require_full_username set to either
> true or false would seem sensible.

This has traditionally been done with hooks, and should stay that way
to be consistent with other Horde applications.

> Discuss?

Sure.
 
> (As an aside, I wasn't sure if anyone was working on passwd at the moment,

Not really.  But it isn't forgotten or anything.

> so wasn't sure which version to submit a patch for. Seems foolish to submit
> a patch to HEAD if it's being worked on!)

Always submit against HEAD.
 
> Peter.

-- 
Eric Rostetter
The Department of Physics
The University of Texas at Austin
 
Why get even? Get odd!