[sync] Turba and Syncml patch proposal

[Chuck Hagenbuch]

Quoting Karsten Fourmont <fourmont at gmx.de>:

> Doing this right may take some time, so the applied patch should do for
> the moment.

Looking through the patch, there are some things in there which are nits but
should still be fixed and shouldn't be in committed code:

+    if(empty($source)) {
+        $source = $conf['client']['addressbook'];
+    }

space between if and (.


          break;
+    case 'text/x-vcard':

a little fuzzier but whenever there are substantial code blocks, you need a
newline between break; and the next case: block.


+    global $cfgSources,$conf;

always need a space after a comma.


It just makes the lives of the core developers a little easier when 
none of this
stuff is in patches or gets into CVS, so that we know we can trust 
people's code
and not spend time reviewing/cleaning it up.

Thanks,
-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams