[sync] Re: XML_WBXML/WBXML/ContentHandler.php patch

[Chuck Hagenbuch]

Quoting Karsten Fourmont <fourmont at gmx.de>:

> here's the patch for Contenthandler.php. Just one single line to 
> avoid creating empty xmlns="" tags:
>
> -        if ((!$currentUri) || ($currentUri != $uri)) {
> +        if (((!$currentUri) || ($currentUri != $uri)) && $uri) {
>              $this->_output .= ' xmlns="' . $uri . '"';
>
>
> Seems pretty OK to me, but I didn't want to commit it without asking 
> first. Contenthandler may be used at various other places, too. Any 
> objections?

None from me - xmlns="" is never valid afaik, so we should definitely 
avoid outputting it. Only question is whether or not $uri being empty 
indicates a bug elsewhere, but that shouldn't prevent this patch from 
being committed. I say go for it.

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams