[sync] all day events

Karsten Fourmont fourmont at gmx.de
Sat Nov 11 00:53:23 PST 2006


 > -       "$1DTEND:${s}T240000", $content);
 > +       "$1DTEND:${s}T000000", $content);
right. committed, thanks.

Cheers,
  Karstne

Håvard Wigtil wrote:
> man, 06,.11.2006 kl. 20.05 +0100, skrev Håvard Wigtil:
>> Karsten Fourmont wrote:
>> > Hi,
>> >
>> > thanks for the feedback. A fix for all day events on the P990 is in cvs
>> > now (only P800.php has changed). Give it a try.
>>
>> Thanks, great work!
>> There is one small problem with the change, though. You can set the date
>> to the day after at 000000, or the same day at 240000, but setting to the
>> day after at 240000 adds an extra day.
>>
>> Tank you for creating a bug so simple that even I could make a patch. ;-)
> 
> Although the patch was missing, even though it was included in the mail 
> I sent.
> Here it is inline, but I'm sure you could have figured this out without 
> me. :-)
> 
> Index: framework/SyncML/SyncML/Device/P800.php
> ===================================================================
> RCS file: /repository/framework/SyncML/SyncML/Device/P800.php,v
> retrieving revision 1.16
> diff -u -r1.16 P800.php
> --- framework/SyncML/SyncML/Device/P800.php     5 Nov 2006 10:01:06 
> -0000       1.16
> +++ framework/SyncML/SyncML/Device/P800.php     6 Nov 2006 19:04:17 -0000
> @@ -117,7 +117,7 @@
>              /* End date must be converted to timestamp. */
>              $s = date('Ymd', mktime(0, 0, 0, $m[3], $m[4]+1, $m[2]));
>              $content = preg_replace('/(\r\n|\r|\n)DTEND:(\d{8})T235959/',
> -                                    "$1DTEND:${s}T240000", $content);
> +                                    "$1DTEND:${s}T000000", $content);
>          }
>  
>          if (!empty($GLOBALS['SyncML_debugDir'])
> 
> --
> Håvard Wigtil <http://håvard.wigtil.net> || http://wigtil.net
> 



More information about the sync mailing list