[sync] Error in Cmd=GetAttachment

[Michael J Rubinsky]

Quoting Jens-Uwe Mozdzen <jmozdzen at nde.ag>:

> Hi Mike,
>
> Zitat von Michael J Rubinsky <mrubinsk at horde.org>:
>> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>>
>>> Not sure why your getting the PHP error though, it should be  
>>> throwing an exception - which is what triggers the 500 response to  
>>> be sent.
>>
>> The PHP error was due to the way I was handling detecting a missing  
>> message. This should now also be fixed in the latest package release.
>
> I upgraded to the latest PEAR code (Horde_ActiveSync 2.1.3) and  
> tried to access an attachment of a deleted message:
>
> PHP Fatal error:  Function name must be a string in  
> /usr/share/php5/PEAR/Horde/ActiveSync/Imap/Adapter.php on line 569
>
> As I have an unrelated local mod in that file, here's the  
> corresponding part of the source:
>
>  564     public function getAttachment($mailbox, $uid, $part)
>  565     {
>  566         $imap = $this->_getImapOb();
>  567         $mbox = new Horde_Imap_Client_Mailbox($mailbox);
>  568         $messages = $this->_getMailMessages($mbox, array($uid));
>  569         if (!$messages[$uid](Horde_Imap_Client::FETCH_STRUCTURE)) {
>  570             throw new Horde_ActiveSync_Exception('Message Gone');
>  571         }
>  572         $msg = new Horde_ActiveSync_Imap_Message($imap, $mbox,  
> $messages[$uid]);
>  573         $part = $msg->getMimePart($part);
>  574
>  575         return $part;
>  576     }
>
> Maybe you used some code only available in git yet?

*sigh* My fault. That's what happens when you fix bugs you can't  
reproduce entirely.

Should be fixed in the just released update.
-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6062 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.horde.org/archives/sync/attachments/20130120/790b256b/attachment-0001.bin>