[trean] adding to My Bookmarks **Patch II**

[Chris Albertson]

This message is in MIME format.

---------------------- multipart/mixed attachment
Yup. That bothered me as well. Another thing is that when you select add 
bookmark from within a category, it didn't select that category by default.
So....
Here is a patch to fix those two items.
1) Removed "My_Bookmarks" as a selection in the add bookmark page.
2) Changed the logic to make it select the category for you if you add from 
within a category.

----------------------------------------------------------------
Change Details::
I didn't delete lines of code from this change. I commented the old lines and 
added mine. All my changes are within the catSelect function within Trean.php.
Changed: 
$sel = ($cat === $selected) ? ' selected="selected"' : '';
--to--
$sel = "";
if ($cat['name'] == $selected) {
    $sel = "selected";
}

and

Removed:
$sel = ('-1' === $selected) ? ' selected="selected"' : '';
$options = '<option value="-1">' . _("My Bookmarks") . "</option>\n"

------------------------------------------------------------------------


Attached is Trean.php. Is should replace the file in horde/trean/lib.

I hope you find this change useful.

-- 
Chris Albertson
alb@chrisalbertson.com

Never be afraid to try something new. 
Remember that amateurs built the ark. Professionals built the Titanic.

4783147098


Quoting Nate Mollring <nmollring@cennecs.org>:

> Quoting Chris Albertson <alb@chrisalbertson.com>:
> 
> > Attached please find "browse.php." This replaces the browse.php that lives
> in
> >
> > the root of trean.
> > I changed the following line:
> >  $show_new_bookmark = !$showBookmarks;
> > --to--
> >  $show_new_bookmark = $showBookmarks;
> >
> > The code for the ability to "not" show the add bookmark menu item was all
> > there, it just had the wrong boolean set.
> > I believe this change will also jive with future releases of trean where
> I'd
> >
> > suspect that additional category/sub-category groupings could be added.
> (ie.
> >
> > another "My_Bookmarks" level item with sub-categories)
> >
> > If you have any questions about this change, please feel free to let me
> know.
> 
> 
> That works when I'm in the browse screen, I like it.  But if you click add in
> the top menu, My Bookmarks is an option still.
> thanks for the modification.
> Nate
> --
> Trean mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: trean-unsubscribe@lists.horde.org

-------------------------------------------------
This email was sent from www.chrisalbertson.com
using IMP mailing program, part of the Horde suite
of information management tools.
http://horde.org/
---------------------- multipart/mixed attachment
PD9waHANCg0KcmVxdWlyZV9vbmNlIFRSRUFOX0JBU0UgLiAnL2xpYi9jb25zdGFudHMucGhwJzsN
Cg0KLyoqDQogKiBUcmVhbiBCYXNlIENsYXNzLg0KICoNCiAqICRIb3JkZTogdHJlYW4vbGliL1Ry
ZWFuLnBocCx2IDEuNCAyMDAyLzA5LzAzIDAxOjUzOjExIGNodWNrIEV4cCAkDQogKg0KICogQGF1
dGhvciBNaWtlIENvY2hyYW5lIDxtaWtlQGdyYWZ0b25oYWxsLmNvLm56Pg0KICogQHZlcnNpb24g
JFJldmlzaW9uOiAxLjQgJA0KICogQHBhY2thZ2UgdHJlYW4NCiAqLw0KY2xhc3MgVHJlYW4gew0K
DQogICAgLyoqDQogICAgICogTGlzdCBhIGNhdGVnb3JpZXMNCiAgICAgKg0KICAgICAqIEByZXR1
cm4gYXJyYXkgQSBsaXN0IG9mIGNhdGVnb3JpZXMuDQogICAgICovDQogICAgZnVuY3Rpb24gbGlz
dENhdGVnb3JpZXMoJHBhcmVudCA9ICctMScpDQogICAgew0KICAgICAgICByZXR1cm4gJF9TRVNT
SU9OWyd0cmVhbiddLT5fYm9va21hcmtzLT5leHBvcnQoQ0FURUdPUllfRk9STUFUX1RSRUUsICRw
YXJlbnQpOw0KICAgIH0NCg0KICAgIC8qKg0KICAgICAqIFRoaXMgZ2VuZXJhdGVzIHRoZSBib2R5
IG9mIGEgJmx0O3NlbGVjdCZndDsgZm9ybSBpbnB1dCB0byBzZWxlY3QgYQ0KICAgICAqIGNhdGVn
b3J5LiBUaGUgJmx0O3NlbGVjdCZndDsgYW5kICZsdDsvc2VsZWN0Jmd0OyB0YWdzIGFyZSBOT1Qg
aW5jbHVkZWQNCiAgICAgKiBpbiB0aGUgb3V0cHV0IG9mIHRoaXMgZnVuY3Rpb24uDQogICAgICoN
CiAgICAgKiBAcGFyYW0gb3B0aW9uYWwgc3RyaW5nICRzZWxlY3RlZCAgVGhlIGNhdGVnb3J5IHRv
IGhhdmUgc2VsZWN0ZWQgYnkNCiAgICAgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgZGVmYXVsdC4gRGVmYXVsdHMgdG8gdGhlIGZpcnN0IG9wdGlvbg0KICAgICAqICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBpbiB0aGUgbGlzdC4NCiAgICAgKg0KICAgICAqIEBy
ZXR1cm4gc3RyaW5nICBBIHN0cmluZyBjb250YWluaW5nIDxvcHRpb24+IGVsZW1lbnRzIGZvciBl
YWNoIGNhdGVnb3J5IA0KICAgICAqICAgICAgICAgICAgICAgICBpbiB0aGUgbGlzdC4NCiAgICAg
Ki8NCiAgICBmdW5jdGlvbiBjYXRTZWxlY3QoJHNlbGVjdGVkID0gbnVsbCkNCiAgICB7DQogICAg
ICAgIHJlcXVpcmVfb25jZSBIT1JERV9CQVNFIC4gJy9saWIvVGV4dC5waHAnOw0KICAgICAgICAN
CiAgICAgICAgJHRyZWUgPSAkX1NFU1NJT05bJ3RyZWFuJ10tPl9ib29rbWFya3MtPmV4cG9ydChD
QVRFR09SWV9GT1JNQVRfVFJFRSwgJy0xJywgdHJ1ZSk7DQogICAgICAgICRjYXRlZ29yaWVzID0g
VHJlYW46Ol9jYXRTZWxlY3QoJHRyZWVbJy0xJ10sIDEpOw0KDQogICAgICAgIC8qICRzZWwgPSAo
Jy0xJyA9PT0gJHNlbGVjdGVkKSA/ICcgc2VsZWN0ZWQ9InNlbGVjdGVkIicgOiAnJzsgKi8NCiAg
ICAgICAgLyogJG9wdGlvbnMgPSAnPG9wdGlvbiB2YWx1ZT0iLTEiPicgLiBfKCJNeSBCb29rbWFy
a3MiKSAuICI8L29wdGlvbj5cbiI7Ki8NCiAgICAgICAgZm9yZWFjaCAoJGNhdGVnb3JpZXMgYXMg
JGNhdCkgew0KCSAgICAkc2VsID0gIiI7DQoJICAgIGlmICgkY2F0WyduYW1lJ10gPT0gJHNlbGVj
dGVkKSB7DQoJICAgICAgICRzZWwgPSAic2VsZWN0ZWQiOw0KCSAgICB9DQogICAgICAgICAgICAv
KiAkc2VsID0gKCRjYXQgPT09ICRzZWxlY3RlZCkgPyAnIHNlbGVjdGVkPSJzZWxlY3RlZCInIDog
Jyc7ICovDQogICAgICAgICAgICAkdmFsID0gaHRtbHNwZWNpYWxjaGFycygkY2F0WyduYW1lJ10p
Ow0KCSAgICAkY2F0b2JqID0gJF9TRVNTSU9OWyd0cmVhbiddLT5nZXRDYXRlZ29yeSgkY2F0Wydu
YW1lJ10pOw0KICAgICAgICAgICAgJGxhYmVsID0gc3RyX3JlcGVhdCgnICAnLCAkY2F0WydkZXB0
aCddKSAuICRjYXRvYmotPmdldE5hbWUoKTsNCiAgICAgICAgICAgICRvcHRpb25zIC49IHNwcmlu
dGYoJzxvcHRpb24gdmFsdWU9IiVzIiVzPiVzPC9vcHRpb24+JXMnLCAkdmFsLCAkc2VsLCBUZXh0
OjpodG1sU3BhY2VzKCRsYWJlbCksICJcbiIpOw0KICAgICAgICB9DQoNCiAgICAgICAgcmV0dXJu
ICRvcHRpb25zOw0KICAgIH0NCg0KICAgIGZ1bmN0aW9uIF9jYXRTZWxlY3QoJHRyZWUsICRkZXB0
aCA9IDApIA0KICAgIHsNCiAgICAgICAgJGNhdCA9IGFycmF5KCk7DQogICAgICAgIA0KICAgICAg
ICBpZiAoaXNfYXJyYXkoJHRyZWUpKSB7DQogICAgICAgICAgICBmb3JlYWNoICgkdHJlZSBhcyAk
bmFtZSA9PiAkYnJhbmNoKSB7DQogICAgICAgICAgICAgICAgJGNhdFtdID0gYXJyYXkoJ25hbWUn
ID0+ICRuYW1lLCAnZGVwdGgnID0+ICRkZXB0aCk7DQogICAgICAgICAgICAgICAgJGNoaWxkcmVu
ID0gVHJlYW46Ol9jYXRTZWxlY3QoJGJyYW5jaCwgJGRlcHRoICsgMSk7DQogICAgICAgICAgICAg
ICAgZm9yZWFjaCAoJGNoaWxkcmVuIGFzICRjaGlsZCkgew0KICAgICAgICAgICAgICAgICAgICAk
Y2F0W10gPSAkY2hpbGQ7DQogICAgICAgICAgICAgICAgfQ0KICAgICAgICAgICAgfQ0KICAgICAg
ICB9DQogICAgICAgIA0KICAgICAgICByZXR1cm4gJGNhdDsNCiAgICB9DQoNCiAgICBmdW5jdGlv
biBsaXN0QWxsQm9va21hcmtzKCRuYW1lID0gJy0xJykgDQogICAgew0KICAgICAgICByZXR1cm4g
JF9TRVNTSU9OWyd0cmVhbiddLT5saXN0QWxsQm9va21hcmtzKCRuYW1lKTsNCiAgICB9DQoNCiAg
ICBmdW5jdGlvbiBmaWx0ZXJBbGxCb29rbWFya3MoJGZpbHRlciwgJG5hbWUgPSAnLTEnKQ0KICAg
IHsNCiAgICAgICAgcmV0dXJuICRfU0VTU0lPTlsndHJlYW4nXS0+ZmlsdGVyQWxsQm9va21hcmtz
KCRmaWx0ZXIsICRuYW1lKTsNCiAgICB9DQogICAgDQogICAgZnVuY3Rpb24gbmV3Q2F0ZWdvcnko
JG5hbWUpDQogICAgew0KICAgICAgICByZXR1cm4gJF9TRVNTSU9OWyd0cmVhbiddLT5uZXdDYXRl
Z29yeSgkbmFtZSk7DQogICAgfQ0KDQogICAgZnVuY3Rpb24gYWRkQ2F0ZWdvcnkoJGNhdCwgJHBh
cmVudCA9ICctMScpDQogICAgew0KICAgICAgICByZXR1cm4gJF9TRVNTSU9OWyd0cmVhbiddLT5h
ZGRDYXRlZ29yeSgkY2F0LCAkcGFyZW50KTsNCiAgICB9DQoNCn0NCg==

---------------------- multipart/mixed attachment--