[whups] Re: library conventions and state of play
Sun, 24 Dec 2000 15:12:12 +0000
Quoting Chuck Hagenbuch <email@example.com>:
> Quoting Anil Madhavapeddy <firstname.lastname@example.org>:
> > I've also got a different style of human-readable diff
> > working locally, that dispenses with the two tables, and uses
> > overstrike and bold to illustrate deleted and added text,
> > which is quite easy on the eyes.
> Great! Maybe add it in as a seperate option? I kind of like the current
> table view, but it'd be _great_ if we could have a CVSLib_DiffViewer class
> (or something like that) which was subclassed into various human-readable
> formats, or plain text, or... :)
Well, amidst munching mince pies, I realised I hadnt yet answered
I decided that the human-readable diff was just a html rendition
of the unified diff, and so shouldn't really have its own class
(since it is presentation layer).
There's a similar argument for the strikethrough diff (which I'm
just mucking around with on my laptop at the moment), so I wont
put it in its own class either.
I'm open to arguments either way though; do you still want to have
a set of CVSLib_diff_* classes for these?
Anil Madhavapeddy, <email@example.com>