[Tickets #1705] Don't use array_push

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=1705
-----------------------------------------------------------------------
 Ticket             | 1705
 Updated By         | selsky at columbia.edu
 Summary            | Don't use array_push
 Queue              | Horde Base
 Version            | HEAD
 State              | Feedback
 Priority           | 1. Low
 Type               | Enhancement
 Owners             | 
-----------------------------------------------------------------------


selsky at columbia.edu (2005-04-07 11:32) wrote:

http://us2.php.net/manual/en/function.array-push.php says:

Note: If you use array_push() to add one element to the  array it's better
to use $array[] = because in that  way there is no overhead of calling a
function.

I'm not positive that it's applicable here since we're calling array(), but
array() isn't a real function.

I only submitted this patch since it took 5 seconds and reduced a few lines
of code that I had added.