[Tickets #4345] sieve: empty allof generates 'false' instead of 'true'

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4345
-----------------------------------------------------------------------
 Ticket             | 4345
 Updated By         | gergely at risko.hu
 Summary            | sieve: empty allof generates 'false' instead of 'true'
 Queue              | Ingo
 Version            | HEAD
 Type               | Bug
 State              | Feedback
 Priority           | 1. Low
 Owners             | Jan Schneider, Ben Chavet
-----------------------------------------------------------------------


gergely at risko.hu (2006-08-29 06:11) wrote:

> You wrote:
>
>> That is anyof, which evaluates to false.
>
> But with your patch it always evaluates to true if no conditions are 
> specified. 

I told you already, that it is not the case.  Please. Apply my patch to a
test directory and test it if you do not believe, but I think it is clear
from the source also.  Since it doesn't patch Sieve_Test_Anyof class, but
Sieve_Test_Allof only.

> But this is an academical discussion anyway, because "if 
> false" doesn't make any sense. "if true" doesn't make much sense 
> either, so I'm tending to disallow any rules that don't have 
> conditions specified.

It will be a big mistake, since I see no other way to create an always
running custom rule, if there is, please enlighten me. Anyway this was the
reason, why I bothered patching it.

gergely