[Tickets #3862] Add support for Date_Holidays

bugs@bugs.horde.org bugs at bugs.horde.org
Mon Oct 16 06:30:37 PDT 2006


DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3862
-----------------------------------------------------------------------
 Ticket             | 3862
 Updated By         | webmaster at dasourcerer.net
 Summary            | Add support for Date_Holidays
 Queue              | Kronolith
 Version            | HEAD
 Type               | Enhancement
 State              | Assigned
 Priority           | 1. Low
 Owners             | Jan Schneider
+New Attachment     | dhpatch.diff
-----------------------------------------------------------------------


webmaster at dasourcerer.net (2006-10-16 06:30) wrote:

Here's an updated patch. There's nothing critical. However, it still would
be better with these changes:

- Prevent the user from selecting the "Composite" driver
Technically there is no harm in doing so. The Composite driver is used to
add other holiday drivers so a set of drivers can be used. It is already
loaded and it doesn't make much sense to add the composite driver to tha
composite driver. So it's no longer available as an option to the user.

- Generate the file location of the translation files in a platform
independent way
I've been using '/' all the time, now replaced with DIRECTORY_SEPARATOR
(Date_Holidays needs the full path to where its translation files are
kept). This might have prevented the translation of holidays on
non-unixoid systems.

Sorry for the inconvenience. I should have thought of this before.




More information about the bugs mailing list