[Tickets #3862] Add support for Date_Holidays

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=3862
-----------------------------------------------------------------------
 Ticket             | 3862
 Updated By         | Jan Schneider <jan at horde.org>
 Summary            | Add support for Date_Holidays
 Queue              | Kronolith
 Version            | HEAD
 Type               | Enhancement
 State              | Assigned
 Priority           | 1. Low
 Owners             | Jan Schneider
-----------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2006-10-16 06:43) wrote:

> - Prevent the user from selecting the "Composite" driver
> Technically there is no harm in doing so. The Composite driver is 
> used to add other holiday drivers so a set of drivers can be used. It 
> is already loaded and it doesn't make much sense to add the composite 
> driver to tha composite driver. So it's no longer available as an 
> option to the user.

I already changed this in my local copy.

> - Generate the file location of the translation files in a platform 
> independent way
> I've been using '/' all the time, now replaced with 
> DIRECTORY_SEPARATOR (Date_Holidays needs the full path to where its 
> translation files are kept). This might have prevented the 
> translation of holidays on non-unixoid systems.

This is not necessary, PHP abstracts the directory separators from the
underlying OS.

Since I've already tweaked your patch locally a bit, I suggest that you
keep your patched version, update once I've committed my version, and then
send a new patch with any remaining changes on your side.