[Tickets #12265] Re: IMAP package throws errors

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12265
------------------------------------------------------------------------------
  Ticket             | 12265
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | IMAP package throws errors
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2013-05-22 10:25) wrote:

> could it happen that the IMAP server invalidates the handle and thus  
> it is now null?

No.  A PHP resource is a specific data type.  It can never be changed  
by PHP itself to a different data type.

> The error is located in Imap sockets protected function _readStream()
> The reason for the flooded error logs is, that the do-while loop is  
> infinite if the stream is NULL, since the "break;" is only called  
> with a vaild stream.
> So even it seems to be a rare occassion whrer the strem handle is  
> NULL, the code should handle such a sittuation correctly.
>
>  have a code proposal ( see attached patch) which handles the NULL  
> handle correctly.

This is not a correct fix.  This simply masks the issue.  It doesn't  
fix anything.

The correct fix is to figure out WHY _stream is null before entering  
that method (i.e. the debug backtrace).  You can use Horde::debug() to  
help you with this, e.g. in _readStream():

if (is_null($this->_stream)) {
     Horde::debug();
     exit;
}