[Tickets #12605] Re: AS: Fix loss of PINGABLE flag

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12605
------------------------------------------------------------------------------
  Ticket             | 12605
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | AS: Fix loss of PINGABLE flag
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2013-08-23 14:44) wrote:


>> -> IMHO we should run collections->updatePingable() on every PING request
>> right before the "// Start waiting for changes" line.

Why? The only time we need to update the flag is if we received the  
FOLDER elements (otherwise, it's an empty request so the collections  
we are marking as pingable are the same ones we just asked the cache  
if they were pingable).

  Also updatePingable()
>> should modify the cache _and_ the current object.

The current object *should* be saved at the end of the PING request so  
this shouldn't be needed. However, looking at the code it appears that  
it's only saved if the PING detects changes. We should ensure it's  
saved for non-empty ping requests as well. Perhaps this is why the  
collection lost the flag?