[Tickets #12605] Re: AS: Fix loss of PINGABLE flag

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12605
------------------------------------------------------------------------------
  Ticket             | 12605
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | AS: Fix loss of PINGABLE flag
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2013-08-23 14:48) wrote:

> when the PIM requests a PING for a folder it didn't sync yet (=fresh  
> account),
> the synckey will be empty and we won't set the collection as pingable.

It shouldn't do this. A SYNC is a MUST before a PING.

> If I'm not mistaken, we need an enum (=state machine) here:
> 0 => not pingable
> 1 => PIM wants ping but we don't have a synckey
> 2 => pingable
>
> what do you think?

We couldn't PING the folder anyway, even if it was marked as PINGABLE  
until we have a valid SYNC performed on the collection, so I'm not  
sure what value keeping track of the client's error in sending the  
PING for collection would be.  I'll have to reread the specs again to  
be sure I'm not missing something here, but I'm 99% positive that this  
is broken client behavior.