[Tickets #12930] Re: AS: Endless loop with Samsung phone

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12930
------------------------------------------------------------------------------
  Ticket             | 12930
  Updated By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | AS: Endless loop with Samsung phone
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2014-01-22 10:02) wrote:

> Changes have been made in Git (master):
>
> commit ae02bbf0279959f2a3d25f7c011e503970fda975
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date:   Wed Jan 22 02:02:52 2014 -0500
>
>     Add support in Horde_ActiveSync for Recipient Cache.
>
>     Needs backend support, but this prevents broken clients from
>     killing the sync completely (see Bug #12930).
>
>  .../lib/Horde/ActiveSync/Collections.php           |   11 +++++++++++
>  .../lib/Horde/ActiveSync/Driver/Base.php           |    4 ++++
>  .../lib/Horde/ActiveSync/Request/Sync.php          |    9 ++++++++-
>  .../Core/lib/Horde/Core/ActiveSync/Driver.php      |   13 +++++++++++++
>  4 files changed, 36 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/ae02bbf0279959f2a3d25f7c011e503970fda975

Nice! I'll test it ASAP.

I think the new code in "public function getFolderUidForBackendId($folderid)"
contains a typo: It accesses "$type" instead of "$id".
-> Buuuuuuuug

I think it should be:
         // Always use RI for recipient cache.
         if ($folderid == 'RI') {
             return $folderid;
         }