[Tickets #12930] Re: AS: Endless loop with Samsung phone

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12930
------------------------------------------------------------------------------
  Ticket             | 12930
  Updated By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | AS: Endless loop with Samsung phone
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2014-01-22 10:11) wrote:

> I think the new code in "public function getFolderUidForBackendId($folderid)"
> contains a typo: It accesses "$type" instead of "$id".
> -> Buuuuuuuug
>
> I think it should be:
>         // Always use RI for recipient cache.
>         if ($folderid == 'RI') {
>             return $folderid;
>         }
>

Ah, the code in Collections.php was copied from  
Driver/Base.php:_getFolderUidForBackendId()
which contains a $type parameter.

I'm extending the Driver/Base.php:_getFolderUidForBackendId() function
to check $type for the correct type OR $id for 'RI'.
Then we support both "modes" if $type is not given.