[Tickets #13105] Re: call of prefs_init() for non-existant user f and entries in history table with history_who == 'f'

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/13105
------------------------------------------------------------------------------
  Ticket             | 13105
  Updated By         | skhorde at smail.inf.fh-bonn-rhein-sieg.de
  Summary            | call of prefs_init() for non-existant user f and
                     | entries in history table with history_who == 'f'
  Queue              | Horde Base
  Version            | 5.1.6
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


skhorde at smail.inf.fh-bonn-rhein-sieg.de (2014-05-16 10:22) wrote:

> Actually, I can't reproduce the problem where a 'f' is being sent as  
> the username to the prefs_init hook. It is always passed as a null  
> value if $registry->getAuth() is false.
>
> If this is still happening for you, please provide a backtrace from  
> within the hook so we can see where it is originating from.

I have added the patch from comment 3 to:

Horde_History             2.3.0   stable

First tested with CalDAV / KDE only:
Before the patch I have gotten 'f' entries in the history_who field,  
after the patch I get no more such entries.

I have also added a logging command to History.php here:

         if (!isset($attributes['who'])) {
             $attributes['who'] = $this->_auth;
         }
         if(!is_string($attributes['who'])) {	/* test userid */

The second if() was triggered _before_ the patch, but never _after_  
applying the patch. So it looks like your patch fixes the problem for  
CalDAV.

I will setup an ActiveSync testbed and report back.