[Tickets #13454] Timeout for external calendar only in Portal

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/13454
------------------------------------------------------------------------------
  Ticket             | 13454
  Created By         | Jasper.Olbrich at students.uni-marburg.de
  Summary            | Timeout for external calendar only in Portal
  Queue              | Kronolith
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Jasper.Olbrich at students.uni-marburg.de (2014-08-19 13:39) wrote:

When an external calendar takes between 5 and 15 seconds to respond,  
it will work in the dynamic kronolith view, but not on the Portal page  
if a calendar block is used

This is because in _getDriver() in  
kronolith/lib/Ajax/Application/Handler.php, we have

         if ($driver == 'remote') {
             $kronolith_driver->setParam('timeout', 15);
         }

But for the function listEvents() in kronolith/lib/Kronolith.php, we have
        $driver = self::getDriver('Ical', $url);
        $events = $driver->listEvents(...);

which uses the default (hard coded) timeout value of 5 seconds. This  
could be fixed by inserting $driver->setParam('timeout', 15); in the  
above snippet, or (better?) improve the method getDriver (which  
already includes a branch for $instance instanceof  
Kronolith_Driver_Ical).

Would it also be good to have those timeout values configurable?