[Tickets #13852] Re: No Virtual Trash

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/13852
------------------------------------------------------------------------------
  Ticket             | 13852
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | No Virtual Trash
  Queue              | IMP
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Slusarz
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2015-02-25 00:37) wrote:

>>> Now that's one of a hidden setting. I never use Virtual Trash, so
>>> when has it been moved there?
>>
>> Between IMP 4 and IMP 5.
>
> I found the old behavior with a checkbox to enable the virtual trash  
> more intuitive. But I don't have a strong opinion about this either.

Having separate "trash" and "virtual trash" options was completely  
unintuitive.  They are the same thing.  Virtual Trash is a *type* of  
trash mailbox; it's not a separate entity.

>>> Now that I was able to enable Virtual Trash, it's broken though:
>>> - You still see deleted messages in the regular mailboxes.
>>
>> Can't reproduce.
>>
>>> - You cannot undelete messages.
>>
>> Fixed.
>
> Needs to be backported too. Thanks!

Unfortunately, this isn't something that is directly backportable  
since message viewing has changed a bunch in IMP 7.  Due to other time  
concerns (which I will hopefully be able to discuss very soon) I don't  
have the time to do the kind of involved backporting necessary for this.

>>> - You can drag messages from the VT to any folder while they stay deleted.
>>
>> The current behavior is correct.  If you "move" a message out of
>> Virtual Trash, it will disappear from virtual trash.  But since the
>> message has a deleted flag, it will "re-appear" when the virtual
>> trash is explicitly refreshed (i.e. the search is run again).  This
>> is consistent semantics with every other search mailbox.
>
> It's not the same completely. Because if you move from a search  
> mailbox to a folder so that it doesn't match the search criteria  
> anymore, it works like a regular mailbox.

Exactly my point.
> And that's the more important point. If we use the folder semantics  
> with search results, we need to use the folder semantics in user  
> interaction too. Where we cannot guarantee this interaction  
> behavior, we need to disable it. If we don't want to re-run the  
> search immediately (which would be the correct behavior) because it  
> is too performance hungry, we need to disable moving out of search  
> folders.

Why?  Again... this is how every mailbox works... when you move a  
message out, it disappears.  And all search mailboxes are not  
refreshed until explicitly told to.  (There is a difference in  
semantics between search and non-search mailboxes, but that is OK  
because there is explicit visual indication - via the searchbar - of  
this difference).

I guess I'm confused what you think you should be seeing.  Moving a  
message out of the Virtual Trash should not cause that message to  
remain in the Virtual Trash.  I'm not sure what other behavior you are  
expecting.  (i.e. moving a message out of Virtual Trash to a different  
mailbox MUST cause the message to be initially removed from the  
virtual trash, since delivery to a mailbox could possibly result in  
the \deleted flag being removed, for example).