[Tickets #14478] Re: Enhanced function of horde-active-sessions

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: https://bugs.horde.org/ticket/14478
------------------------------------------------------------------------------
  Ticket           | 14478
  Aktualisiert Von | Jan Schneider <jan at horde.org>
  Zusammenfassung  | Enhanced function of horde-active-sessions
  Warteschlange    | Horde Base
  Version          | 5.2.12
  Typ              | Enhancement
  Status           | Feedback
  Priorität        | 1. Low
  Milestone        |
  Patch            | 1
  Zuständige       |
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2016-10-14 16:41) hat geschrieben:

>> - The -ll output should probably stay as-is, if people already rely
>> on the output, scripting it in some way
>>   - -lll should be used instead for the more detailed information
>>   - -ll could still receive the optional user parameter.
>
> Ok.
>
>> - You may want to switch to Horde_Argv because the parameter parsing
>> is getting complicated:
>> https://www.horde.org/libraries/Horde_Argv/docs/README
>
> In my first try it does'nt accept -ll
> exception 'Horde_Argv_OptionException' with message 'invalid long  
> option string '-ll': must start with --, followed by non-dash' in  
> /usr/share/pear/Horde/Argv/Option.php:323

Ah, okay. Then we probably have to stick with the current argument  
parsing, to maintain backward compatibility.

>> - You should check the return value of $sessionHandler->destroy()
>
> Is it boolean? Or shall I use a try ... catch?

It's a boolean.

>> - You should only output the number of sessions with the -l* flags.
>
> Ok.
>
> Frank