[Tickets #14830] horde-translation does not work anymore on code downloaded via pear

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: https://bugs.horde.org/ticket/14830
------------------------------------------------------------------------------
  Ticket           | 14830
  Erstellt Von     | wahnes at uni-koeln.de
  Zusammenfassung  | horde-translation does not work anymore on code
                   | downloaded via pear
  Warteschlange    | Horde Base
  Version          | 5.2.18
  Typ              | Bug
  Status           | Unconfirmed
  Priorität        | 2. Medium
  Milestone        |
  Patch            |
  Zuständige       |
------------------------------------------------------------------------------


wahnes at uni-koeln.de (2018-07-06 11:01) hat geschrieben:

With the changes introducted between version 5.2.17 and 5.2.18, the  
/usr/bin/horde-translation script does not work properly when trying  
to generate new MO files from PO files edited locally after a release  
of the Horde package has been downloaded via pear.

Around line 407 of horde-translation, in the strip_horde function, the  
5.2.18 version introduces a reference to Horde_Yaml which the Horde  
pear package does not depend on. With Horde_Yaml installed, the  
strip_horde function still fails as there is no ".horde.yml" file in a  
pear downloaded Horde package.

The code of the strip_horde function in the older version used  
str_replace to do the work, which worked fine in the case that there  
is no git checkout involved.