[chora] A few issues with cvs-head

[Dan Wilson]

Quoting Chuck Hagenbuch <chuck@horde.org>:

> Quoting Dan Wilson <dan@acucore.com>:
> 
> > 1) Is there a reason the full name of the author is not displayed (or am I
> > missing an option).  I tracked this down to a second parameter of true not
> > being passed into Chora::showAuthorName on line 96 of cvs.php.  There is 
> > another call on line 190 that does have the second parameter.  Just
> > wondering what the different is (I didn't study the code much) and if I 
> > shouldn't have changed that specific call.
> 
> Not displayed _where_ ?

Sorry, not enough info.  It only displays the username, not the full name in 
the directory listing.  I was just thinking that someone probably didn't like 
it displaying the full name to shorten the length of the row or something.  
But I would prefer that it show the full name.  Don't know how everyone else 
feels about it.

> > 2) In the parseCVSUsers function in CVSLib.php it assumes that the first
> > line of the cvsusers file is header info.  However, mine is not (I know, 
> > it's not typical), so it wasn't displaying the username correctly for my 
> > first user in the file.  Shouldn't we try to detect and see if that's 
> > header info or not before discarding it?
> > 
> > I really should submit this as a patch, but I'm not sure if this is by
> > design or not.
> 
> A patch to handle this would be great.

My problem here is that I don't have a cvsusers file that actually has a 
header in it.  So I'm not sure of the format.  I'm assuming that we could just 
check for a comment character (#) at the beginning of the line, but I'm not 
positive.

Thanks,
-Dan