[chora] A few issues with cvs-head

Chuck Hagenbuch chuck@horde.org
Sat, 3 Aug 2002 21:49:22 -0400


Quoting Dan Wilson <dan@acucore.com>:

> 1) Is there a reason the full name of the author is not displayed (or am I
> missing an option).  I tracked this down to a second parameter of true not
> being passed into Chora::showAuthorName on line 96 of cvs.php.  There is 
> another call on line 190 that does have the second parameter.  Just
> wondering what the different is (I didn't study the code much) and if I 
> shouldn't have changed that specific call.

Not displayed _where_ ?

> 2) In the parseCVSUsers function in CVSLib.php it assumes that the first
> line of the cvsusers file is header info.  However, mine is not (I know, 
> it's not typical), so it wasn't displaying the username correctly for my 
> first user in the file.  Shouldn't we try to detect and see if that's 
> header info or not before discarding it?
> 
> I really should submit this as a patch, but I'm not sure if this is by
> design or not.

A patch to handle this would be great.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"After a few minutes the most aromatic and nice smelling Italian coffee 
 will come out of the exhaustpipe." - Our stove-top espresso pot