[chora] Re: PHP script for viewing subversion repositories

[Jay Freeman (saurik)]

Chuck:

When I did the merge I noticed a few disturbing conflicts...

    116 <<<<<<< Directory.php
    117                 $fl = &$this->rep->getFileObject(substr($path,
strlen($this->rep->sourceroot()), -2), $flags);
    118 =======
    119                 $fl = &$GLOBALS['VC']->getFileObject(substr($path,
strlen($GLOBALS['VC']->sourceroot()), -2), $flags);
    120 >>>>>>> 1.24

Changing everything to use the VC global variable _seriously_ limits the
usefulness of the library... in that last patch I believe I actually went to
the trouble to change a few of those that I noticed that weren't needed (as
this->rep was valid) to using this->rep. This assumes that you will only
connect to one repository at a time... that's a really evil limitation for
what's seeming like a rather good general purpose CVS/SVN library.

Sincerely,
Jay Freeman (saurik)
saurik at saurik.com

----- Original Message -----
From: "Chuck Hagenbuch" <chuck at horde.org>
To: "Jay Freeman (saurik)" <saurik at saurik.com>
Cc: <wiz at groupnetwork.com>; <chora at lists.horde.org>; <redoz at redoz.com>
Sent: Wednesday, August 27, 2003 9:02 AM
Subject: Re: [chora] Re: PHP script for viewing subversion repositories


> Quoting "Jay Freeman (saurik)" <saurik at saurik.com>:
>
> > OK, actually... I have a much MUCH better version of that patch :).
> >
> > ftp://ftp.saurik.com/pub/chora/chora-svn-2b
>
> *snip*
>
> > Note that this change _also_ has a really, really cool side effect. You
now
> > specify the "location" for the repository as a URL to the repository. So
it
> > might be file:///vcs/svn/myrepos if it's locally, but now you can do
> > http://svn.collab.net/repos/svn and have it just feed off the WebDAV.
>
> That's *very* cool. Committed, thanks!
>
> -chuck
>
> --
> Charles Hagenbuch, <chuck at horde.org>
> They're just looking at a wall of meat.