imp/templates/menu/menu.inc (was main.inc)

[Brent J. Nordquist]

It looks like sometime between 2.2.3 and 2.2.4, this CVS archive file was
renamed from main.inc to menu.inc?  (Perhaps for HEAD's benefit?)  If I
have that right, just wanted to raise this issue, because I don't agree
with that approach when released code (STABLE_2_2) is involved.

(a)  I'm of the opinion that archive files should never be deleted or
renamed, because if you do you can't go back in time and regenerate the
exact content of a previous release.  I think the old file should be
attic'ed and its content created as the initial revision of a new file
(new CVS archive).  This causes a break in the CVS log (history), which is
unfortunate, but I think it's a price worth paying.

(b)  Our release tarball script doesn't handle this case, and I'm not sure
how it could easily be made to handle it automatically.  As a result we
would have to keep track of CVS archive files renamed/deleted and plan to
handle them at the next release for all maintained branches... manual
handling is a pain, and risky.

(c)  There's no audit trail when you rename/delete out in the file system;
no one knows it happened unless it's mentioned.

I wish CVS allowed for revisioned renaming.  :-)  Other thoughts?  Tx.

-- 
Brent J. Nordquist <bjn@horde.org>
Yahoo!: Brent_Nordquist / AIM: BrentJNordquist / ICQ: 76158942



>From chuck@horde.org Date: Sat,  3 Feb 2001 12:41:52 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 70834 invoked from network); 3 Feb 2001 17:42:46 -0000
Received: from r94aag005136.sbo-smr.ma.cable.rcn.com (HELO marina.horde.org) (209.6.192.126)
  by horde.org with SMTP; 3 Feb 2001 17:42:46 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 1D1E139F5; Sat,  3 Feb 2001 12:41:52 -0500 (EST)
Received: from 192.168.0.1 ( [192.168.0.1])
	as user chuck@marina by marina.your.mom with HTTP;
	Sat,  3 Feb 2001 12:41:52 -0500
Message-ID: <981222112.3a7c42e0746aa@marina.your.mom>
Date: Sat,  3 Feb 2001 12:41:52 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [dev] imp/templates/menu/menu.inc (was main.inc)

Quoting "Brent J. Nordquist" <bjn@horde.org>:

> I wish CVS allowed for revisioned renaming.  :-)  Other thoughts?  Tx.

Yeah. I have to take the blame for this one. I think, in the future, that if we
need to rename something - that's present in multiple branches, especially - we
should copy the archive file, and then cvs delete the old file in the new
revision. That'll leave it in any old branches for tracking... sound good?

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"My intuitive grasp of math often leads me astray." -Me