[dev] prefs locking

[Chuck Hagenbuch]

Quoting Max Kalika <max@the-triumvirate.net>:

> Currently if some prefs are locked, they still show up in the options
> screens.  

I just committed a slightly different fix; everywhere else we're checking 
$prefs->isLocked($pref), instead of the $_prefs array directly, so I was 
consistent with that.

The consequence of this is that the locked/unlocked bits are set once you log 
in. Is this what we want? Or if an admin locks a pref, do we immediately want 
to lock it for all current sessions?

(also, just btw: if (!isset($_prefs[$pref]['locked']) || !$_prefs[$pref]
['locked']) ... can be written as just: if (!empty($_prefs[$pref]['locked']), 
with the side effect that if there's no setting we implicitly lock things, 
which is probably better anyway...)

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"We have no fuel on board, plus or minus 8 kilograms." -A NASA scientist