[cvs] commit: horde/config html.php.dist imp folders.php imp/config html.php.dist troll newsgroups.php troll/config html.php.dist troll/templates/newsgroups head.inc row.inc

[Jon Parise]

On Wed, Mar 07, 2001 at 04:45:37AM -0000, Chuck Hagenbuch wrote:

>   Modified files:
>     config               html.php.dist 
>     .                    folders.php 
>     config               html.php.dist 
>     .                    newsgroups.php 
>     config               html.php.dist 
>     templates/newsgroups head.inc row.inc 
>   Log:
>   - fix things so that the newsgroup browser alternates row colors
>   - move the alternating row colors into horde's html config, and up the contrast a bit
>   - fix an indentation problem with the newsgroup browser
   
I've noticed a lot of our commits span multiple cvs modules.  The
above is an example of a commit that hits a lot of code with a common
log message.  I don't think this is the best practice.

To prevent myself from doing this, I editing horde/CVS/Entries and
removed all of the directory entries for the Horde applications that I
have checked out.  This stops cvs from traversing the entire hierarchy
and forces me to commit (and update) on a per-application basis.

Not only does this confine commits to a single cvs "entity", but it
also enforces the mindset that we're actually dealing with separate
code trees.  I find that last point exceptionally important when we
consider the 'horde' tree is common, shared code.  Changes to it
should not be grouped with application-specific changes.

Well, back to reading more software engineering articles.  This was a
pretty-good read, btw:

    http://www.gamasutra.com/features/20010119/warden_01.htm

-- 
Jon Parise (jon@csh.rit.edu)  .  Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/  :  Computer Science House Member


>From chuck@horde.org Date: Wed,  7 Mar 2001 00:20:08 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 89433 invoked from network); 7 Mar 2001 05:21:10 -0000
Received: from 208-59-250-206.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com (HELO marina.horde.org) (208.59.250.206)
  by horde.org with SMTP; 7 Mar 2001 05:21:10 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id E63913CA4; Wed,  7 Mar 2001 00:20:08 -0500 (EST)
Received: from 192.168.0.110 ( [192.168.0.110])
	as user chuck@localhost by marina.your.mom with HTTP;
	Wed,  7 Mar 2001 00:20:08 -0500
Message-ID: <983942408.3aa5c50884487@marina.your.mom>
Date: Wed,  7 Mar 2001 00:20:08 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [dev] Re: [cvs] commit: horde/config html.php.dist imp folders.php imp/config html.php.dist troll newsgroups.php troll/config html.php.dist troll/templates/newsgroups head.inc row.inc

Quoting Jon Parise <jon@csh.rit.edu>:

> I've noticed a lot of our commits span multiple cvs modules.  The
> above is an example of a commit that hits a lot of code with a common
> log message.  I don't think this is the best practice.

I think it depends a bit on the context - this particular commit was nearly all 
changes that were directly related, and I think it makes sense to keep those 
together. I could have seperated one or two things out, but the html.php 
changes simply don't make sense without the entire set of them.

Now, this does point out that it's a change that shouldn't be made once we 
claim to have a stable Horde API and independently-evolving apps. But while 
things are still in flux, I think it makes sense to keep related changes 
together.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"Live, from Washington, where the doctors were telling us what they did, and
 did not, do with Vice President Cheney." -Dan Rather