[dev] Re: [cvs] commit: kronolith/lib WeekView.php kronolith/templates/edit edit.inc

[Jon Parise]

On Thu, Aug 09, 2001 at 01:43:29PM -0400, Rich Lafferty wrote:

> > >   Log: Fix a few more display issues. Basically, we handle all day
> > >   events by making them take up the span of the amount of day that
> > >   would be displayed if they weren't there. We do this by shifting
> > >   their effective (displayed) start times up if no other criteria
> > >   would cause us to start displaying the day. We were doing this
> > >   at the wrong time - before we'd checked every single day - and
> > >   because of that, under certain circumstances, events would be
> > >   displayed more than once, causing bad html breakage and
> > >   confusion.
> >    
> > Now _that_ is a quality commit message. =)
> 
> I wish I had something trivial to fix right now, so I could commit it
> with "Fixed." :-)
 
I think that would be an appropriate commit message for a
complete documentation rewrite.  Feel free. =)

-- 
Jon Parise (jon@csh.rit.edu)  .  Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/  :  Computer Science House Member


>From chuck@horde.org Date: Thu,  9 Aug 2001 13:46:11 -0400
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 70152 invoked from network); 9 Aug 2001 17:48:15 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.198.7)
  by horde.org with SMTP; 9 Aug 2001 17:48:15 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 6266039F6; Thu,  9 Aug 2001 13:46:11 -0400 (EDT)
Received: from 206.243.191.252 ( [206.243.191.252])
	as user chuck@localhost by marina.horde.org with HTTP;
	Thu,  9 Aug 2001 13:46:11 -0400
Message-ID: <997379171.3b72cc63420f4@marina.horde.org>
Date: Thu,  9 Aug 2001 13:46:11 -0400
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <20010809155334.64479.qmail@horde.org> <20010809134200.B1177@csh.rit.edu>
In-Reply-To: <20010809134200.B1177@csh.rit.edu>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [dev] Re: [cvs] commit: kronolith/lib WeekView.php kronolith/templates/edit edit.inc

Quoting Jon Parise <jon@horde.org>:

> Now _that_ is a quality commit message. =)

I was about to leave it at "Fix a few more display issues.", and then decided 
that the display code is confusing enough and I needed to document my thought 
process _somewhere_. :)

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
Some fallen angels have their good reasons.