[dev] PEAR dsn parser bug in DB.php

Jon Parise jon@horde.org
Wed, 3 Oct 2001 20:30:49 -0400
Previous message: [dev] IMP maint fix for sent-mail rename|delete OK
Next message: Documentation
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Wed, Oct 03, 2001 at 05:28:50PM -0500, Alex L wrote:

> I propse that line 1 of the code above (line 462 in /lib/php/PEAR/DB.php) be 
> changed 
> to: 
> 
> if (($at = strrpos($dsn,'@')) !== false) { 
> 
> This would simply mean that it will take all the text before the last @ 
> character instead of before the first. Domain names can never have an @ symbol, 
> but passwords can, so I see this as a reasonably thing to do. I personally 
> tested this before the patch with the password p@ssword and it failed, then 
> after applying the fix, using p@ssword as the password worked.
 
I reviewed your change, and it look like the right thing to do
for me, too.  I just committed your change to PEAR cvs.  It won't
ship with a PHP release until PHP 4.0.8, however.

-- 
Jon Parise (jon@csh.rit.edu)  .  Information Technology (2001)
http://www.csh.rit.edu/~jon/  :  Computer Science House Member


>From admin@networkessence.net Date: Wed,  3 Oct 2001 23:22:56 -0500
Return-Path: <admin@networkessence.net>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 87697 invoked from network); 4 Oct 2001 04:27:12 -0000
Received: from www.networkessence.net (HELO ns.networkessence.net) (root@216.40.211.25)
  by clark.horde.org with SMTP; 4 Oct 2001 04:27:12 -0000
Received: (from root@localhost)
	by ns.networkessence.net (8.10.2/8.10.2) id f944Muc01416
	for dev@lists.horde.org; Wed, 3 Oct 2001 23:22:56 -0500
Received: from 65.112.179.8 ( [65.112.179.8])
	as user admin@127.0.0.1 by www.networkessence.net with HTTP;
	Wed,  3 Oct 2001 23:22:56 -0500
Message-ID: <1002169376.3bbbe4206e811@www.networkessence.net>
Date: Wed,  3 Oct 2001 23:22:56 -0500
From: Alex L <admin@networkessence.net>
To: dev@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Originating-IP: 65.112.179.8
Subject: Fix needed in whups



There is an inconsitancy with the Ticket creation in whups. When 
clicking 'create ticket', the modules and types are listed. This is is derived 
from the respective SQL tables starting with the first ID in the table till the 
last. But, when clicking 'create', the data entered is validated on whether the 
aluves are empty or not. This is inconsistent because, if a 'type' or 'module' 
id is '0', it is technically empty, but is still listed in the drop down menu. 
Example, the first 'module' in the 'modules' table has an id of 0, and a name 
of foo. The first 'type' in the 'types' table has an id of 0, a name of bar and 
a description of bleh. When the user clicks create script, his choices for the 
module will only be foo, and for types will only be bar. The user 
clicks 'submit'. The form then comes back with an error for both drop-down's 
saying '*Module Name is required', and '*Ticket type is required'. Conclusion, 
consitancy needs to be setup between the form validator code and the form drop-
down menu creator code. I will be working on performing this with my own 
distribution, but just wanted to point this out so it's in the archive so if 
someone gets whups and can't create a ticket they know why :)



-Alex

-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/


>From admin@networkessence.net Date: Wed,  3 Oct 2001 23:38:10 -0500
Return-Path: <admin@networkessence.net>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 89798 invoked from network); 4 Oct 2001 04:42:26 -0000
Received: from www.networkessence.net (HELO ns.networkessence.net) (root@216.40.211.25)
  by clark.horde.org with SMTP; 4 Oct 2001 04:42:26 -0000
Received: (from root@localhost)
	by ns.networkessence.net (8.10.2/8.10.2) id f944cAX02255
	for dev@lists.horde.org; Wed, 3 Oct 2001 23:38:10 -0500
Received: from 65.112.179.8 ( [65.112.179.8])
	as user admin@127.0.0.1 by www.networkessence.net with HTTP;
	Wed,  3 Oct 2001 23:38:10 -0500
Message-ID: <1002170290.3bbbe7b290aef@www.networkessence.net>
Date: Wed,  3 Oct 2001 23:38:10 -0500
From: Alex L <admin@networkessence.net>
To: dev@lists.horde.org
References: <1002169376.3bbbe4206e811@www.networkessence.net>
In-Reply-To: <1002169376.3bbbe4206e811@www.networkessence.net>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Originating-IP: 65.112.179.8
Subject: Re: [dev] Fix needed in whups





I looked at some more code and ran into two thoughts. Either the entire 
validator code needs to be changed, or a restriction needs to be set such that 
the module and type table do not contains ID's of 0. The code for validating 
the forms is:

    $form1->validate($vars);
    $form2->validate($vars);

While obviously, this is using a function, it is generic and uses a validating 
API, so making an API change for just one thing would be a little rough. I 
think the best thing is to create a WHUPS management interface or something so 
that the 'system' databases are administered through the interface instead of 
manually. First, that would be easier anyways, second I think a management 
interface would be a good thing to add, and third, any little proprietary, non-
minor things can be approached much more easily with code than changing 
something at an API level. As soon as I figure something out, I will post it. 
Whether you go with what I work out or not is OK, I'll use it no matter what to 
stay consistent.



Quoting Alex L <admin@networkessence.net>:

> 
> 
> There is an inconsitancy with the Ticket creation in whups. When 
> clicking 'create ticket', the modules and types are listed. This is is
> derived 
> from the respective SQL tables starting with the first ID in the table till
> the 
> last. But, when clicking 'create', the data entered is validated on whether
> the 
> aluves are empty or not. This is inconsistent because, if a 'type' or
> 'module' 
> id is '0', it is technically empty, but is still listed in the drop down
> menu. 
> Example, the first 'module' in the 'modules' table has an id of 0, and a name
> 
> of foo. The first 'type' in the 'types' table has an id of 0, a name of bar
> and 
> a description of bleh. When the user clicks create script, his choices for
> the 
> module will only be foo, and for types will only be bar. The user 
> clicks 'submit'. The form then comes back with an error for both drop-down's
> 
> saying '*Module Name is required', and '*Ticket type is required'.
> Conclusion, 
> consitancy needs to be setup between the form validator code and the form
> drop-
> down menu creator code. I will be working on performing this with my own 
> distribution, but just wanted to point this out so it's in the archive so if
> 
> someone gets whups and can't create a ticket they know why :)
> 
> 
> 
> -Alex
> 
> -------------------------------------------------
> This mail sent through IMP: http://horde.org/imp/
> 
> -- 
> Horde Developers mailing list: http://horde.org/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe@lists.horde.org
> 




-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/


>From jan@horde.org Date: Thu,  4 Oct 2001 09:58:28 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 99934 invoked from network); 4 Oct 2001 08:04:29 -0000
Received: from mailout06.sul.t-online.com (HELO mailout06.sul.t-online.de) (194.25.134.19)
  by clark.horde.org with SMTP; 4 Oct 2001 08:04:29 -0000
Received: from fwd02.sul.t-online.de 
	by mailout06.sul.t-online.de with smtp 
	id 15p3Ua-0001ki-06; Thu, 04 Oct 2001 10:04:28 +0200
Received: from linux.wg.de (320034214675-0001@[217.80.111.21]) by fmrl02.sul.t-online.com
	with esmtp id 15p3U5-0thmHAC; Thu, 4 Oct 2001 10:03:57 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f947wSc12887
	for <dev@lists.horde.org>; Thu, 4 Oct 2001 09:58:28 +0200
Received: from 62.225.101.66 ( [62.225.101.66])
	as user jan@mail.wg.de by jan.dip.ammma.net with HTTP;
	Thu,  4 Oct 2001 09:58:28 +0200
Message-ID: <1002182308.3bbc16a44eda4@jan.dip.ammma.net>
Date: Thu,  4 Oct 2001 09:58:28 +0200
From: Jan Schneider <jan@horde.org>
To: dev@lists.horde.org
References: <1002142762.3bbb7c2a8e898@webmail.lauwerscollege.nl>
In-Reply-To: <1002142762.3bbb7c2a8e898@webmail.lauwerscollege.nl>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [dev] Updated Dutch translations

Will be commited in a moment.

Thanks, Jan.

Zitat von Jan Kuipers <jrkuipers@lauwerscollege.nl>:

> Updated translations for Horde, Gollem, IMP, Kronolith, Nag and Turba can
> be
> found here:
> 
> http://home.wanadoo.nl/~jrkuipers/nl_NL_031001.tar.gz
> 
> -- 
> Jan Kuipers,
> Systeembeheer Lauwers College
> 
> -- 
> Horde Developers mailing list: http://horde.org/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe@lists.horde.org
> 
> 


:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From jan@horde.org Date: Thu,  4 Oct 2001 10:26:45 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 3490 invoked from network); 4 Oct 2001 08:34:33 -0000
Received: from mailout04.sul.t-online.com (HELO mailout04.sul.t-online.de) (194.25.134.18)
  by clark.horde.org with SMTP; 4 Oct 2001 08:34:33 -0000
Received: from fwd05.sul.t-online.de 
	by mailout04.sul.t-online.de with smtp 
	id 15p3xg-00017u-03; Thu, 04 Oct 2001 10:34:32 +0200
Received: from linux.wg.de (320034214675-0001@[217.80.111.21]) by fmrl05.sul.t-online.com
	with esmtp id 15p3xJ-066eLQC; Thu, 4 Oct 2001 10:34:09 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f948Qkc13058
	for <dev@lists.horde.org>; Thu, 4 Oct 2001 10:26:46 +0200
Received: from 62.225.101.66 ( [62.225.101.66])
	as user jan@mail.wg.de by jan.dip.ammma.net with HTTP;
	Thu,  4 Oct 2001 10:26:45 +0200
Message-ID: <1002184005.3bbc1d45cb591@jan.dip.ammma.net>
Date: Thu,  4 Oct 2001 10:26:45 +0200
From: Jan Schneider <jan@horde.org>
To: dev@lists.horde.org
References: <1002142762.3bbb7c2a8e898@webmail.lauwerscollege.nl>
In-Reply-To: <1002142762.3bbb7c2a8e898@webmail.lauwerscollege.nl>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [dev] Updated Dutch translations

The archive seems to be corrupt. Can you check this?

Jan.

Zitat von Jan Kuipers <jrkuipers@lauwerscollege.nl>:

> Updated translations for Horde, Gollem, IMP, Kronolith, Nag and Turba can
> be
> found here:
> 
> http://home.wanadoo.nl/~jrkuipers/nl_NL_031001.tar.gz
> 
> -- 
> Jan Kuipers,
> Systeembeheer Lauwers College
> 
> -- 
> Horde Developers mailing list: http://horde.org/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe@lists.horde.org
> 
> 


:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From jrkuipers@lauwerscollege.nl Date: Thu,  4 Oct 2001 10:58:20 +0200
Return-Path: <jrkuipers@lauwerscollege.nl>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 5049 invoked from network); 4 Oct 2001 08:58:52 -0000
Received: from c3207.upc-c.chello.nl (HELO linux.lauwerscollege.nl) (212.187.3.207)
  by clark.horde.org with SMTP; 4 Oct 2001 08:58:52 -0000
Received: (from www@localhost)
	by linux.lauwerscollege.nl (8.11.6/8.8.7) id f948wK908622
	for dev@lists.horde.org; Thu, 4 Oct 2001 10:58:20 +0200
Received: from 172.17.0.134 ( [172.17.0.134])
	as user jrkuipers@localhost by webmail.lauwerscollege.nl with HTTP;
	Thu,  4 Oct 2001 10:58:20 +0200
Message-ID: <1002185900.3bbc24ac28dc6@webmail.lauwerscollege.nl>
Date: Thu,  4 Oct 2001 10:58:20 +0200
From: Jan Kuipers <jrkuipers@lauwerscollege.nl>
To: dev@lists.horde.org
References: <1002142762.3bbb7c2a8e898@webmail.lauwerscollege.nl> <1002184005.3bbc1d45cb591@jan.dip.ammma.net>
In-Reply-To: <1002184005.3bbc1d45cb591@jan.dip.ammma.net>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [dev] Updated Dutch translations

Citeren Jan Schneider <jan@horde.org>:

> The archive seems to be corrupt. Can you check this?
It was :(
I uploaded again.

http://home.wanadoo.nl/~jrkuipers/nl_NL_031001.tar.gz

-- 
Jan Kuipers,
Systeembeheer Lauwers College


>From jrkuipers@lauwerscollege.nl Date: Thu,  4 Oct 2001 11:11:46 +0200
Return-Path: <jrkuipers@lauwerscollege.nl>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 7164 invoked from network); 4 Oct 2001 09:15:27 -0000
Received: from c3207.upc-c.chello.nl (HELO linux.lauwerscollege.nl) (212.187.3.207)
  by clark.horde.org with SMTP; 4 Oct 2001 09:15:27 -0000
Received: (from www@localhost)
	by linux.lauwerscollege.nl (8.11.6/8.8.7) id f949Bki08713
	for dev@lists.horde.org; Thu, 4 Oct 2001 11:11:46 +0200
Received: from 212.187.3.207 ( [212.187.3.207])
	as user jrkuipers@localhost by webmail.lauwerscollege.nl with HTTP;
	Thu,  4 Oct 2001 11:11:46 +0200
Message-ID: <1002186706.3bbc27d212612@webmail.lauwerscollege.nl>
Date: Thu,  4 Oct 2001 11:11:46 +0200
From: Jan Kuipers <jrkuipers@lauwerscollege.nl>
To: dev@lists.horde.org
References: <1002142762.3bbb7c2a8e898@webmail.lauwerscollege.nl> <1002184005.3bbc1d45cb591@jan.dip.ammma.net> <1002185900.3bbc24ac28dc6@webmail.lauwerscollege.nl>
In-Reply-To: <1002185900.3bbc24ac28dc6@webmail.lauwerscollege.nl>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [dev] Updated Dutch translations

Citeren Jan Kuipers <jrkuipers@lauwerscollege.nl>:

> Citeren Jan Schneider <jan@horde.org>:
> 
> > The archive seems to be corrupt. Can you check this?
> It was :(
> I uploaded again.

Ignore this one:
 
http://home.wanadoo.nl/~jrkuipers/nl_NL_031001.tar.gz

Pick this:

http://home.wanadoo.nl/~jrkuipers/nl_NL_041001.tar.gz

I renamed the file ??????

-- 
Jan Kuipers,
Systeembeheer Lauwers College


>From jan@horde.org Date: Thu,  4 Oct 2001 11:24:11 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 8740 invoked from network); 4 Oct 2001 09:34:29 -0000
Received: from mailout02.sul.t-online.com (HELO mailout02.sul.t-online.de) (194.25.134.17)
  by clark.horde.org with SMTP; 4 Oct 2001 09:34:29 -0000
Received: from fwd00.sul.t-online.de 
	by mailout02.sul.t-online.de with smtp 
	id 15p4tf-0004ia-02; Thu, 04 Oct 2001 11:34:27 +0200
Received: from linux.wg.de (320034214675-0001@[217.80.111.21]) by fmrl00.sul.t-online.com
	with esmtp id 15p4tI-1URBKKC; Thu, 4 Oct 2001 11:34:04 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f949OCc13343
	for <dev@lists.horde.org>; Thu, 4 Oct 2001 11:24:12 +0200
Received: from 62.225.101.66 ( [62.225.101.66])
	as user jan@mail.wg.de by jan.dip.ammma.net with HTTP;
	Thu,  4 Oct 2001 11:24:11 +0200
Message-ID: <1002187451.3bbc2abba1d81@jan.dip.ammma.net>
Date: Thu,  4 Oct 2001 11:24:11 +0200
From: Jan Schneider <jan@horde.org>
To: dev@lists.horde.org
References: <1002142762.3bbb7c2a8e898@webmail.lauwerscollege.nl> <1002184005.3bbc1d45cb591@jan.dip.ammma.net> <1002185900.3bbc24ac28dc6@webmail.lauwerscollege.nl> <1002186706.3bbc27d212612@webmail.lauwerscollege.nl>
In-Reply-To: <1002186706.3bbc27d212612@webmail.lauwerscollege.nl>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [dev] Updated Dutch translations

OK, this one works.

Jan.

Zitat von Jan Kuipers <jrkuipers@lauwerscollege.nl>:

> Citeren Jan Kuipers <jrkuipers@lauwerscollege.nl>:
> 
> > Citeren Jan Schneider <jan@horde.org>:
> > 
> > > The archive seems to be corrupt. Can you check this?
> > It was :(
> > I uploaded again.
> 
> Ignore this one:
>  
> http://home.wanadoo.nl/~jrkuipers/nl_NL_031001.tar.gz
> 
> Pick this:
> 
> http://home.wanadoo.nl/~jrkuipers/nl_NL_041001.tar.gz
> 
> I renamed the file ??????
> 
> -- 
> Jan Kuipers,
> Systeembeheer Lauwers College
> 
> -- 
> Horde Developers mailing list: http://horde.org/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe@lists.horde.org
> 
> 


:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From jan@horde.org Date: Fri,  5 Oct 2001 11:40:23 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 72956 invoked from network); 5 Oct 2001 09:44:15 -0000
Received: from mailout06.sul.t-online.com (HELO mailout06.sul.t-online.de) (194.25.134.19)
  by clark.horde.org with SMTP; 5 Oct 2001 09:44:15 -0000
Received: from fwd06.sul.t-online.de 
	by mailout06.sul.t-online.de with smtp 
	id 15pRWf-0007Mm-09; Fri, 05 Oct 2001 11:44:13 +0200
Received: from linux.wg.de (320034214675-0001@[217.80.111.25]) by fmrl06.sul.t-online.com
	with esmtp id 15pRWO-0S3GL2C; Fri, 5 Oct 2001 11:43:56 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f959eNc21198;
	Fri, 5 Oct 2001 11:40:23 +0200
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@mail.wg.de by linux.wg.de with HTTP;
	Fri,  5 Oct 2001 11:40:23 +0200
Message-ID: <1002274823.3bbd800731bbe@linux.wg.de>
Date: Fri,  5 Oct 2001 11:40:23 +0200
From: Jan Schneider <jan@horde.org>
To: "dev@lists.horde.org" <dev@lists.horde.org>, horde@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: No gettext in horde domain

Hi, 

does anybody know, why the the gettext strings that belong to the horde domain 
are not translated correctly. You can see that for example on the summary 
screen. 

I already checked: the correct locale, domain and path are set. 

Jan. 

:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::
Previous message: [dev] IMP maint fix for sent-mail rename|delete OK
Next message: Documentation
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]