[dev] Re: [cvs] cvs commit: imp/lib/Maintenance/Task purge_trash.php

[Jan Schneider]

Zitat von Chuck Hagenbuch <chuck@horde.org>:

> Quoting Jan Schneider <jan@ammma.de>:
> 
> >   Another folder prefix where it doesn't belong.
> 
> Except, we put the prefixes _back_ just recently.

Hm, I already thought that something was wrong with this commit, but then 
there is something else messed up.

My current setup has the namespace set to 'INBOX.' but event after you 
latest changes my folder preferences get stored as e.g. INBOX.Trash. When 
this function (in purge_trash.php) prepends the prefix another time, I end 
up in {mail:143/imap}INBOX.INBOX.Trash.

I must say I'm currently a bit lost how and when we strip or prepend folder 
prefixes or namespaces.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft


>From chuck@horde.org Date: Sat,  9 Feb 2002 21:37:07 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 78484 invoked from network); 10 Feb 2002 02:37:45 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.196.127)
  by clark.horde.org with SMTP; 10 Feb 2002 02:37:45 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id E0CC939E6; Sat,  9 Feb 2002 21:37:07 -0500 (EST)
Received: from 192.168.0.131 ( [192.168.0.131])
	as user chuck@localhost by marina.horde.org with HTTP;
	Sat,  9 Feb 2002 21:37:07 -0500
Message-ID: <1013308627.3c65dcd3b33a1@marina.horde.org>
Date: Sat,  9 Feb 2002 21:37:07 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <20020210015051.D98D74DA@arkady.horde.org> <1013306413.3c65d42d3ceb0@marina.horde.org> <1013307639.3c65d8f7ccf5d@jan.dip.ammma.net>
In-Reply-To: <1013307639.3c65d8f7ccf5d@jan.dip.ammma.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [dev] Re: [cvs] cvs commit: imp/lib/Maintenance/Task purge_trash.php

Quoting Jan Schneider <jan@horde.org>:

> Hm, I already thought that something was wrong with this commit, but then 
> there is something else messed up.

http://cvs.horde.org/co.php/imp/identities.php?r=2.26

Read the commit message. We shouldn't be storing prefixes in the user 
preferences, which means we need to strip them before storing them and put them 
back when using them.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"What was and what may be, lie, like children whose faces we cannot see, in the
arms of silence. All we ever have is here, now." - Ursula K. Le Guin