[dev] Horde patches

Jan Kuipers jrkuipers@lauwerscollege.nl
Sat, 16 Mar 2002 00:09:53 +0100


Citeren Cliff Green <green@UMDNJ.EDU>:

>   <tr><td align="center" colspan="2" class="header">
> -   <?php printf(_("Welcome to %s"), (Auth::getProvider() == 'imp') ? \
> $registry->getParam('name', 'horde') : $registry->getParam('name')) ?> 
>   </td></tr>
> --- 62,64 ----
>   <tr><td align="center" colspan="2" class="header">
> +   <?php printf(_("Welcome to %s"), (Auth::getProvider() == 'imp') ? \
> $registry->getParam(($registry->getParam('banner')) ? 'banner' : 'name', \
> 'horde') : $registry->getParam('name')) ?>
>   </td></tr>

Hello Cliff,
Nice! Your solution seems a bit more flexibel, when it comes to text you want 
on the loginscreen, however there is a little inconsistency when you would 
apply this to gollem and _not_ having a 'banner' variable in the gollem 
registry, it uses the one declared in Horde and that may not be a suitable text 
for the Gollem loginscreen. So a 'banner' variable should also be in the Gollem 
registry. When it's empty, the 'name' variable of Gollem is used.

-- 
Jan Kuipers
Systeembeheer Lauwers College