[dev] Re: [cvs] commit: imp compose.php imp/lib Folder.php

Jon Parise jon@horde.org
Thu, 23 May 2002 13:20:06 -0400


On Tue, May 21, 2002 at 11:27:30PM -0400, Chuck Hagenbuch wrote:

> > Don't you find it inconsistent and unintuitive for users of these class
> > if some methods take the folder argument encoded and some decoded. This 
> > is definitely a source of confusion that would leed to more discussions
> > like this in the future.
> 
> I guess I can see this. I think we should add IMP_Folder::encode() and 
> IMP_Folder::decode(), for completeness, and stipulate that folder names 
> passed to IMP_Folder::create() must already be encoded, or must be passed 
> through IMP_Folder::encode() first. I can live with that approach. That 
> does mean we need to change every occurrence of IMP_Folder::create() in 
> the code (and the same should go for IMP_Folder::exists()).
 
Whatever gets decided, please document it appropriately in the header
comments.

-- 
Jon Parise (jon@csh.rit.edu)  .  Information Technology (2001)
http://www.csh.rit.edu/~jon/  :  Computer Science House Member