[dev] Re: [cvs] commit: horde/lib/MIME/Viewer tgz.php horde/docs CHANGES horde/config mime_drivers.php.dist

[Michael Cochrane]

One mistake :-)

Also we are using the filename as the key thoughout the code... this causes a
few issues with returning files from the archives as the key we need to pass
around is the filename.

Can we change this to a simple counter? and have the filename as another value.
Also there's nothing to stop two identically named files in an archive. If so
I'm happy to do the changes, I have a TGZ viewer for IMP done that will produces
the same list but the filenames are now links to the individual files.

- Mike :-)

Index: lib/MIME/Viewer/tgz.php
===================================================================
RCS file: /httpd/horde/horde/lib/MIME/Viewer/tgz.php,v
retrieving revision 1.17
diff -I$Horde -I$Revision -I$Date -r1.17 tgz.php
127c127
<                     $files[$key]['attr']  = ($info['typeflag'] -= 0x35) ? 'd'
: '-';
---
>                     $files[$key]['attr']  = ($info['typeflag'] == 0x35) ? 'd'
: '-';


Quoting Michael M Slusarz <slusarz@bigworm.colorado.edu>:

> slusarz     2002/06/16 22:52:02 PDT
> 
>   Modified files:
>     lib/MIME/Viewer      tgz.php 
>     docs                 CHANGES 
>     config               mime_drivers.php.dist 
>   Log:
>   Submitted by: Michael Cochrane <mike@graftonhall.co.nz>
>   Tar/gzip now handled entirely internally by MIME_Viewer.
>   
>   Revision  Changes    Path
>   1.43      +3 -3      horde/config/mime_drivers.php.dist
>   1.291     +2 -0      horde/docs/CHANGES
>   1.17      +167 -28   horde/lib/MIME/Viewer/tgz.php
> 
>   Chora Links:
>  
>
http://cvs.horde.org/diff.php/horde/config/mime_drivers.php.dist?r1=1.42&r2=1.43&ty=u
>   http://cvs.horde.org/diff.php/horde/docs/CHANGES?r1=1.290&r2=1.291&ty=u
>  
> http://cvs.horde.org/diff.php/horde/lib/MIME/Viewer/tgz.php?r1=1.16&r2=1.17&ty=u
> 
> -- 
> To unsubscribe, mail: cvs-unsubscribe@lists.horde.org




-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/