[dev] Re: [cvs] commit: horde/lib Prefs.php horde/lib/Prefs ldap.php session.phpsql.php

[Jon Parise]

On Thu, Jul 18, 2002 at 11:42:55AM -0700, Michael M Slusarz wrote:

> slusarz     2002/07/18 11:42:55 PDT
> 
>   Modified files:
>     lib                  Prefs.php 
>     lib/Prefs            ldap.php session.php sql.php 
>   Log:
>   General code cleanup/consolidation of some duplicate code.
>   sql/ldap were setting the 'default' entry in the $prefs hash - they should
>   be using setDefault() instead.
>   The Prefs:: class now automatically updates any preference with the dirty
>   bit set at the end of a request via a shutdown function. Thus, there is no
>   need to manually call a $prefs->store() at the end of a script anymore.
   
I can't say that I care much for the comment reformatting and the
breakage with regard to 80-column friendliness, both of which I
consider unnecessary, but you're overall changes look quite good.
Nice work!

-- 
Jon Parise (jon@horde.org) :: The Horde Project (http://horde.org/)