[dev] Re: [cvs] commit: forwards/lib/Driver forwards.php

Eric Rostetter eric.rostetter@physics.utexas.edu
Mon, 7 Oct 2002 08:27:40 -0500


Quoting Jan Schneider <jan@ammma.de>:

> jan         2002/10/07 04:41:03 PDT
> 
>   Modified files:
>     lib/Driver           forwards.php
>   Log:
>   Fix call-by-reference.
> 
>   Revision  Changes    Path
>   1.6       +6 -6      forwards/lib/Driver/forwards.php
> 
>   Chora Links:
>  
> http://cvs.horde.org/diff.php/forwards/lib/Driver/forwards.php?r1=1.5&r2=1.6&ty=u

Doesn't this break the function?  It desires to change the value globally,
which I would have thought would mean it has to be passed in as a reference
or declared as a global.  So if we don't want the pass by reference, don't
we at least need to make it a global?

I suppose we could rewrite the module to not need this code, but since the code
is there, I'd like it to work, and my concern is that the above breaks the
code.

(Same change was made to vacation module BTW).

-- 
Eric Rostetter
The Department of Physics
The University of Texas at Austin

Why get even? Get odd!