[dev] Quota 'NO LIMIT' Bug - reopen?

Mike Cochrane mike@graftonhall.co.nz
Wed Nov 20 10:16:52 2002


> ----- Message from Leena.Heino@uta.fi ---------
> 
> On Tue, 19 Nov 2002, Marcus I. Ryan wrote:
> 
> > http://bugs.horde.org/show_bug.cgi?id=1033
> >
> > I agree with the user here, except I think we should just get rid of
> > "!empty($user)".  I don't see what it breaks.  I've tried it on my
> > system with a user in all four situations and haven't seen any results.
> >  Any reason I'm missing here as to why I should just get rid of that and
> > recommit it?
> In Cyrus IMAP if user has unlimited quota then the return values will be
> empty. So this check is necessary.
> 
> I agree with the bug reporter that the if statement in Quota.php should be
> corrected to:
> if (isset($used) && !empty($total)) {

I'm happy for anyone to commit changes to the code, I didn't have a mailserver
that supported quota when I ported it from the config file examples.
I'm just confused as to how to differentiate between these cases:

User has no mail but a quota (eg new user)
 - You get empty array (what to show? error?)

User had no qouta set and may or may not have messages.
 - You get empty array (show NO LIMIT)

- Mike :-)



More information about the dev mailing list