[dev] NIV: DNS Lookup feature patch

[Chuck Hagenbuch]

Quoting Florian Clever <fc@clever-soft.net>:

> attached is an attempt to produce a patch adding DNS Lookup support for
> the NIC module to add DNS support. Please give me feedback on the patch
> format or just a simple "Your code sucks" would work just as well.
> There are two new files added: nic/dns.php and nic/templates/dns/dns.inc.
> Those are simply attached as I do not know how to include them in the
> patch.

Looks good to me - committed, thanks!

> - Icon for DNS (I am not that good with images, but I will make unless
> somebody volunteers)

I just set it to the same one as the IP lookup for now. Better suggestions
(for either) welcome.

> Also I have a few more general questions:
> - Coding Conventions: I would propose adding conventions about variable
> and function naming. Also a strict convention on how Class and library 
> names translate to file names and path.

Okay. I think some of those are there, but if you submitted a draft of what
you think should be added to this list, that'd be great.

> - I am assuming bugzilla will at some point be replaced with WHUPS. Once
> WHUPS is mature enough.

Correct. Mostly when we have time to migrate to Whups.

> - dead code policy. This might not be necessary as there are probably no
> FDA reviews of Horde coming up.

Eh?

> - Which OS are "supposed" to be supported? Linux, Win32, Solaris only? Or
> also MacOS X, HP-UX, AIX?

Anything that runs PHP. And you certainly can't leave out the BSDs, which
you didn't mention at all. :)

> - Licenses: The coding conventions state either LGPL or GPL. But the code
> in the NIC module states BSD?

Where does it say that? Ah, I see - those are just examples. Any open source
license is probably acceptable; BSD is usually preffered for new apps.

> This project rocks! (Of course).

Thanks!

> PS: I have access to some Solaris, Linux and windows servers. I might be
> able to check a few things for portability.

That'd be great.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"People ask me all the time what it will be like living without otters."
 - Google, thanks to Harpers