[dev] NIC: DNS Lookup feature patch

[Florian Clever]

> Looks good to me - committed, thanks!
thanks.

> > Also I have a few more general questions:
> > - Coding Conventions: I would propose adding conventions about variable
> > and function naming. Also a strict convention on how Class and library
> > names translate to file names and path.
>
> Okay. I think some of those are there, but if you submitted a
> draft of what
> you think should be added to this list, that'd be great.
Alright I will try to draft something at some point.

> > - I am assuming bugzilla will at some point be replaced with WHUPS. Once
> > WHUPS is mature enough.
>
> Correct. Mostly when we have time to migrate to Whups.
I saw you sort of started today.

> > - Which OS are "supposed" to be supported? Linux, Win32,
> Solaris only? Or
> > also MacOS X, HP-UX, AIX?
>
> Anything that runs PHP. And you certainly can't leave out the BSDs, which
> you didn't mention at all. :)
Oops. Forgot about those. I will see what I can do in terms of testing on
Solaris.

> > - Licenses: The coding conventions state either LGPL or GPL.
> But the code
> > in the NIC module states BSD?
>
> Where does it say that? Ah, I see - those are just examples. Any
> open source
> license is probably acceptable; BSD is usually preffered for new apps.
Aha I see.

thanks,
Flori

Florian Clever

Clever Software Solutions
http://www.clever-soft.com/