[dev] Data::imc should split on [\r\n], not just \n

Chuck Hagenbuch chuck at horde.org
Mon Jan 13 17:02:40 PST 2003


Quoting John Morrissey <jwm at horde.net>:

> Data::imc should be splitting lines on [\r\n] instead of just \n - if it
> doesn't, Data::icalendar can wind up in an infinite loop when viewing
> .ics files. Patch attached.

Committed, thanks.

> Also, I noticed that the newline character(s) are determined by
> Data::getNewline(). This means that any event invitations sent by the
> user will use the line terminator preferred by his host OS. Somehow this
> doesn't seem right (what about the recipient's platform?), but I can't 
> think of a clean way to fix it.

Well, it's right for cases when the user is exporting something to their own
computer. And it's not really *worse* for other cases.

-chuck

--
Charles Hagenbuch, <chuck at horde.org>
must ... find ... acorns ... *thud*


More information about the dev mailing list