[dev] Re: [imp] whitelist patch...

[Chuck Hagenbuch]

Quoting Jan Schneider <jan at horde.org>:

> That's not quite the correct solution, and I can't imagine this was what
> Chuck had in mind.
> API methods should never use the $notification object itself but always
> return a PEAR_Error. The problem with the current code is not that it
> returns an error object but that it is inconsistent and stops after the
> first failing address.

This is what I meant, yes.

> As we're discussing the IMP/black-/whitelist interaction here: I'm not 
> sure anymore if it's a good idea to redirect to the black/whitelist screen
> after submitting addresses. Sure it's the only way to correct any 
> accidently submitted address or to finetune them. But now that not only 
> IMP provides this feature, it's hard to get back to the original screen, 
> once you are in Sam or Ingo.

I agree - I've been noticing lately that this is annoying.

-chuck

--
Charles Hagenbuch, <chuck at horde.org>
I know there's fish out there, but where g-d only knows.