[dev] Re: [cvs] commit: whups/lib Admin.php Create.php

[Marko Djukic]

a couple of points came up whilst fixing these files...
- maybe it could be useful having a setParams() type call (similar to
setDefault()) to set up the params after an addVariable()?
- would it be good to have a 'yesno' variable type, as it is being used
repeatedly in a number of apps?
- would it be useful to having a setInvalidCondition() function as part of the
variable class, which would have the variable set to invalid type based on a
certain condition? something like:
  $somevar = &$this->addVariable(..........);
  $somevar->setInvalidCondition($foo < $bar, _("not enough foo"));
could cut out quite a bit of code/complexity when setting up... but not sure if
it would do anything about overhead? or maybe some other similar solution...

marko

Quoting Marko Djukic <tech at oblo.com>:

> mdjukic     2003/03/26 20:04:16 PST
> 
>   Modified files:
>     lib                  Admin.php Create.php
>   Log:
>   use the new Form.php syntax for setting up variables.
>   could do with a second pass to clean up some variable usage.
> 
>   this was a rather big file to update, i might have missed some typo. if
> anyone has this installed and running, i would really appreciate to get some
> feedback if anything is broke or not, thanks.
> 
>   Revision  Changes    Path
>   1.33      +184 -189  whups/lib/Admin.php
>   1.33      +28 -26    whups/lib/Create.php
> 
>   Chora Links:
>   http://cvs.horde.org/diff.php/whups/lib/Admin.php?r1=1.32&r2=1.33&ty=u
>   http://cvs.horde.org/diff.php/whups/lib/Create.php?r1=1.32&r2=1.33&ty=u
> 
> --
> To unsubscribe, mail: cvs-unsubscribe at lists.horde.org
>